darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 15:15:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused functions

Browse Source 
Can't see these being used anywhere so lets get rid of them
This commit is contained in:
David McDonald
2022-02-07 15:23:08 +00:00
parent 4018fcba28
commit 1d8fafcdf4
3 changed files with 1 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -17,12 +17,10 @@ from app.dao.notifications_dao import (
dao_get_notification_count_for_job_id,
dao_get_notification_or_history_by_reference,
dao_get_notifications_by_recipient_or_reference,
dao_get_notifications_by_references,
dao_timeout_notifications,
dao_update_notification,
dao_update_notifications_by_reference,
get_notification_by_id,
get_notification_for_job,
get_notification_with_personalisation,
get_notifications_for_job,
get_notifications_for_service,
@@ -503,14 +501,6 @@ def test_save_notification_no_job_id(sample_template):
assert data.get('job_id') is None
def test_get_notification_for_job(sample_notification):
notification_from_db = get_notification_for_job(
sample_notification.service.id,
sample_notification.job_id,
sample_notification.id)
assert sample_notification == notification_from_db
def test_get_all_notifications_for_job(sample_job):
for _ in range(0, 5):
try:
@@ -1602,17 +1592,6 @@ def test_dao_get_notification_by_reference_with_no_matches_raises_error(notify_d
dao_get_notification_by_reference('REF1')
def test_dao_get_notifications_by_references(sample_template):
create_notification(template=sample_template, reference='noref')
notification_1 = create_notification(template=sample_template, reference='ref')
notification_2 = create_notification(template=sample_template, reference='ref')
notifications = dao_get_notifications_by_references(['ref'])
assert len(notifications) == 2
assert notifications[0].id in [notification_1.id, notification_2.id]
assert notifications[1].id in [notification_1.id, notification_2.id]
def test_dao_get_notification_or_history_by_reference_with_one_match_returns_notification(
sample_letter_template
):