darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-20 14:29:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change the name of letter_class to postage, this will match the domain language used in the documentation.

Browse Source 
Updated the tests to answer review comments.
This commit is contained in:
Rebecca Law
2018-09-18 15:22:08 +01:00
parent efb618e956
commit 1c0892888f
8 changed files with 74 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/dao/services_dao.py
View File

@@ -167,7 +167,7 @@ def dao_create_service(service, user, service_id=None, service_permissions=None)
service.active = True
service.research_mode = False
service.crown = service.organisation_type == 'central'
service.letter_class = 'second'
service.postage = 'second'
for permission in service_permissions:
service_permission = ServicePermission(service_id=service.id, permission=permission)
@@ -181,7 +181,8 @@ def dao_create_service(service, user, service_id=None, service_permissions=None)
@transactional
@version_class(Service)
def dao_update_service(service):
service.letter_class = service.letter_class or 'second'
print("service.postage: ", service.postage)
service.postage = service.postage or 'second'
db.session.add(service)

2
app/models.py
View File

@@ -353,7 +353,7 @@ class Service(db.Model, Versioned):
crown = db.Column(db.Boolean, index=False, nullable=False, default=True)
rate_limit = db.Column(db.Integer, index=False, nullable=False, default=3000)
contact_link = db.Column(db.String(255), nullable=True, unique=False)
letter_class = db.Column(db.String(255), index=False, nullable=True)
postage = db.Column(db.String(255), index=False, nullable=True)
organisation = db.relationship(
'Organisation',