darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Document behaviour of s3 letter deleting

Browse Source 
The behaviour was a bit of opaque so I have added tests around it so
it's clear what it is doing and why. No functionality has changed
This commit is contained in:
David McDonald
2020-12-16 10:39:31 +00:00
parent 219023f4c6
commit 1bf9b29905
3 changed files with 48 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/dao/notifications_dao.py
View File

@@ -428,7 +428,9 @@ def _delete_letters_from_s3(
).limit(query_limit).all()
for letter in letters_to_delete_from_s3:
bucket_name = current_app.config['LETTERS_PDF_BUCKET_NAME']
# I don't think we need this anymore, we should update the query to get letters sent 7 days ago
# although letters without a `sent_at` timestamp do have PDFs, they do not exist in the
# production-letters-pdf bucket as they never made it that far so we do not try and delete
# them from it
if letter.sent_at:
prefix = get_letter_pdf_filename(reference=letter.reference,
crown=letter.service.crown,