darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor method for deciding the failure type

Browse Source
This commit is contained in:
Rebecca Law
2021-03-10 10:39:17 +00:00
parent a7a504a599
commit 19f7a6ce38
5 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/notifications/test_process_client_response.py
View File

@@ -67,7 +67,7 @@ def test_process_sms_client_response_updates_notification_status(
('101', 'permanent-failure', 'Unknown Subscriber'),
('102', 'temporary-failure', 'Absent Subscriber'),
(None, 'temporary-failure', None),
('000', 'temporary-failure', None)
('000', 'temporary-failure', 'No error reported')
])
def test_process_sms_client_response_updates_notification_status_when_called_second_time(
sample_notification,
@@ -82,7 +82,7 @@ def test_process_sms_client_response_updates_notification_status_when_called_sec
process_sms_client_response('1', str(sample_notification.id), 'Firetext', detailed_status_code)
if detailed_status_code and detailed_status_code != '000':
if detailed_status_code:
message = f'Updating notification id {sample_notification.id} to status {expected_notification_status}, reason: {reason}' # noqa
mock_logger.assert_called_with(message)