darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 17:01:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Delete unused function

Browse Source
This commit is contained in:
Katie Smith
2020-03-16 15:50:00 +00:00
parent 900664c172
commit 19bf68b567
2 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/notifications/process_client_response.py
View File

@@ -117,8 +117,3 @@ def _process_for_status(notification_status, client_name, provider_reference):
success = "{} callback succeeded. reference {} updated".format(client_name, provider_reference) success = "{} callback succeeded. reference {} updated".format(client_name, provider_reference)
return success return success
def set_notification_sent_by(notification, client_name):
notification.sent_by = client_name
dao_update_notification(notification)

8
tests/app/notifications/test_process_client_response.py
View File

@@ -114,14 +114,6 @@ def test_process_sms_updates_billable_units_if_zero(sample_notification):
assert sample_notification.billable_units == 1 assert sample_notification.billable_units == 1
def test_process_sms_does_not_update_sent_by_if_already_set(mocker, sample_notification):
mock_update = mocker.patch('app.notifications.process_client_response.set_notification_sent_by')
sample_notification.sent_by = 'MMG'
process_sms_client_response(
status='3', provider_reference=str(sample_notification.id), client_name='MMG')
assert not mock_update.called
def test_process_sms_response_returns_error_bad_reference(mocker): def test_process_sms_response_returns_error_bad_reference(mocker):
success, error = process_sms_client_response( success, error = process_sms_client_response(
status='000', provider_reference='something-bad', client_name='sms-client') status='000', provider_reference='something-bad', client_name='sms-client')