darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor schema and improve tests

Browse Source
This commit is contained in:
Ken Tsang
2017-05-26 17:17:15 +01:00
parent 56e9faab2e
commit 18b8382d6e
2 changed files with 5 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/schemas.py
View File

@@ -186,18 +186,6 @@ class ServiceSchema(BaseSchema):
def service_permissions(self, service):
permissions = [p.permission for p in service.permissions]
def deprecate_convert_flags_to_permissions():
def convert_flags(flag, permission):
if flag and permission not in permissions:
permissions.append(permission)
elif flag is False and permission in permissions:
permissions.remove(permission)
convert_flags(service.can_send_international_sms, INTERNATIONAL_SMS_TYPE)
convert_flags(service.can_send_letters, LETTER_TYPE)
deprecate_convert_flags_to_permissions()
return permissions
class Meta: