darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add updated history count to dao_update_notifications_by_reference

Browse Source 
For returned letter updates most notifications won't exist in the
notifications table, so in order to find out whether the reference
matches any known letters we need to check the count of updated
history records.
This commit is contained in:
Alexey Bezhan
2018-08-30 14:27:57 +01:00
parent 0dcf04def9
commit 18ab7f3337
4 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -1653,10 +1653,13 @@ def test_dao_update_notifications_by_reference_updated_notificaitons_and_history
notification_1 = create_notification(template=sample_template, reference='ref')
notification_2 = create_notification(template=sample_template, reference='ref')
updated_count = dao_update_notifications_by_reference(references=['ref'],
update_dict={"status": "delivered",
"billable_units": 2}
)
updated_count, updated_history_count = dao_update_notifications_by_reference(
references=['ref'],
update_dict={
"status": "delivered",
"billable_units": 2
}
)
assert updated_count == 2
updated_1 = Notification.query.get(notification_1.id)
assert updated_1.billable_units == 2
@@ -1665,6 +1668,7 @@ def test_dao_update_notifications_by_reference_updated_notificaitons_and_history
assert updated_2.billable_units == 2
assert updated_2.status == 'delivered'
assert updated_history_count == 2
updated_history_1 = NotificationHistory.query.get(notification_1.id)
assert updated_history_1.billable_units == 2
assert updated_history_1.status == 'delivered'
@@ -1676,22 +1680,28 @@ def test_dao_update_notifications_by_reference_updated_notificaitons_and_history
def test_dao_update_notifications_by_reference_returns_zero_when_no_notifications_to_update(notify_db):
updated_count = dao_update_notifications_by_reference(references=['ref'],
update_dict={"status": "delivered",
"billable_units": 2}
)
updated_count, updated_history_count = dao_update_notifications_by_reference(
references=['ref'],
update_dict={
"status": "delivered",
"billable_units": 2
}
)
assert updated_count == 0
assert updated_history_count == 0
def test_dao_update_notifications_by_reference_set_returned_letter_status(sample_letter_template):
notification = create_notification(template=sample_letter_template, reference='ref')
updated_count = dao_update_notifications_by_reference(
updated_count, updated_history_count = dao_update_notifications_by_reference(
references=['ref'],
update_dict={"status": "returned-letter"}
)
assert updated_count == 1
assert updated_history_count == 1
assert Notification.query.get(notification.id).status == 'returned-letter'