mirror of
https://github.com/GSA/notifications-api.git
synced 2026-02-02 17:31:14 -05:00
Add new endpoint to get available inbound number.
Add new endpoint to allocate a specific number to a given service. This will allow the platform admin user to choose a number when setting the inbound_sms permission for a service.
This commit is contained in:
@@ -1,3 +1,5 @@
|
||||
import uuid
|
||||
|
||||
from app.dao.inbound_numbers_dao import dao_get_inbound_number_for_service
|
||||
from app.models import ServiceSmsSender
|
||||
|
||||
@@ -129,3 +131,59 @@ def test_allocate_inbound_number_insert_update_service_sms_sender(
|
||||
assert service_sms_senders[0].sms_sender == inbound_number.number
|
||||
assert service_sms_senders[0].inbound_number_id == inbound_number.id
|
||||
assert service_sms_senders[0].is_default
|
||||
|
||||
|
||||
def test_allocate_inbound_number_to_service(admin_request, notify_db_session):
|
||||
service = create_service()
|
||||
inbound_number = create_inbound_number(number='1235468')
|
||||
|
||||
admin_request.post(
|
||||
'inbound_number.allocate_inbound_number_to_service',
|
||||
_expected_status=204,
|
||||
service_id=service.id,
|
||||
inbound_number_id=inbound_number.id
|
||||
)
|
||||
sms_sender = ServiceSmsSender.query.filter_by(service_id=service.id).first()
|
||||
assert sms_sender.sms_sender == inbound_number.number
|
||||
assert sms_sender.inbound_number_id == inbound_number.id
|
||||
|
||||
|
||||
def test_allocate_inbound_number_to_service_returns_404_if_service_does_not_exist(
|
||||
admin_request, notify_db_session
|
||||
):
|
||||
inbound_number = create_inbound_number(number='1235468')
|
||||
|
||||
admin_request.post(
|
||||
'inbound_number.allocate_inbound_number_to_service',
|
||||
_expected_status=404,
|
||||
service_id=uuid.uuid4(),
|
||||
inbound_number_id=inbound_number.id
|
||||
)
|
||||
|
||||
|
||||
def test_allocate_inbound_number_to_service_returns_500_if_inbound_number_is_assigned(
|
||||
admin_request, notify_db_session
|
||||
):
|
||||
service = create_service()
|
||||
inbound_number = create_inbound_number(number='1235468', service_id=service.id)
|
||||
|
||||
admin_request.post(
|
||||
'inbound_number.allocate_inbound_number_to_service',
|
||||
_expected_status=404,
|
||||
service_id=uuid.uuid4(),
|
||||
inbound_number_id=inbound_number.id
|
||||
)
|
||||
|
||||
|
||||
def test_get_available_inbound_numbers_returns_empty_list(admin_request):
|
||||
result = admin_request.get('inbound_number.get_available_inbound_numbers')
|
||||
|
||||
assert result['data'] == []
|
||||
|
||||
|
||||
def test_get_available_inbound_numbers(admin_request, sample_inbound_numbers):
|
||||
result = admin_request.get('inbound_number.get_available_inbound_numbers')
|
||||
|
||||
assert len(result['data']) == 1
|
||||
assert result['data'] == [i.serialize() for i in sample_inbound_numbers if
|
||||
i.service_id is None]
|
||||
|
||||
Reference in New Issue
Block a user