darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-05 02:41:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add new endpoint to get available inbound number.

Browse Source 
Add new endpoint to allocate a specific number to a given service.

This will allow the platform admin user to choose a number when setting the inbound_sms permission for a service.
This commit is contained in:
Rebecca Law
2017-09-21 15:18:52 +01:00
parent e6d6b6f985
commit 18581c754a
5 changed files with 112 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/app/dao/test_inbound_numbers_dao.py
View File

@@ -6,8 +6,8 @@ from app.dao.inbound_numbers_dao import (
dao_get_inbound_number_for_service,
dao_get_available_inbound_numbers,
dao_set_inbound_number_to_service,
dao_set_inbound_number_active_flag
)
dao_set_inbound_number_active_flag,
dao_allocate_number_for_service)
from app.models import InboundNumber
from tests.app.db import create_service, create_inbound_number
@@ -79,3 +79,21 @@ def test_set_inbound_number_active_flag(notify_db, notify_db_session, sample_ser
inbound_number = dao_get_inbound_number_for_service(sample_service.id)
assert inbound_number.active is active
def test_dao_allocate_number_for_service(notify_db_session):
number = '078945612'
inbound_number = create_inbound_number(number=number)
service = create_service()
updated_inbound_number = dao_allocate_number_for_service(service_id=service.id, inbound_number_id=inbound_number.id)
assert service.get_inbound_number() == number
assert updated_inbound_number.service_id == service.id
def test_dao_allocate_number_for_service(notify_db_session, sample_service):
number = '078945612'
inbound_number = create_inbound_number(number=number, service_id=sample_service.id)
service = create_service(service_name="Service needs an inbound number")
with pytest.raises(Exception):
dao_allocate_number_for_service(service_id=service.id, inbound_number_id=inbound_number.id)