darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 15:31:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Downgrade the error message to a warning.

Browse Source
This commit is contained in:
Rebecca Law
2017-11-03 12:09:20 +00:00
parent efe0f3b99b
commit 168231f3ce
2 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notifications/notifications_ses_callback.py
View File

@@ -76,7 +76,7 @@ def process_ses_response(ses_request):
) )
if not notification: if not notification:
warning = "SES callback failed: notification either not found or already updated " \ warning = "SES callback failed: notification either not found or already updated " \
"from sending. Status {} for notification reference {}".format(notification_status, reference) "from sending. Status {} for notification reference {}".format(notification_status, reference)
current_app.logger.warning(warning) current_app.logger.warning(warning)
return return

15
tests/app/notifications/test_notifications_ses_callback.py
View File

@@ -16,7 +16,7 @@ def test_ses_callback_should_not_need_auth(client):
data=ses_notification_callback(), data=ses_notification_callback(),
headers=[('Content-Type', 'text/plain; charset=UTF-8')] headers=[('Content-Type', 'text/plain; charset=UTF-8')]
) )
assert response.status_code == 400 assert response.status_code == 200
def test_ses_callback_should_fail_if_invalid_json(client, mocker): def test_ses_callback_should_fail_if_invalid_json(client, mocker):
@@ -48,16 +48,6 @@ def test_ses_callback_should_fail_if_missing_message_id(client, mocker):
stats_mock.assert_not_called() stats_mock.assert_not_called()
def test_ses_callback_should_fail_if_notification_cannot_be_found(notify_db, notify_db_session, client, mocker):
stats_mock = mocker.patch(
'app.notifications.notifications_ses_callback.create_outcome_notification_statistic_tasks'
)
errors = process_ses_response(json.loads(ses_invalid_notification_id_callback()))
assert errors == 'SES callback failed: notification either not found or already updated from sending. Status delivered for notification reference missing' # noqa
stats_mock.assert_not_called()
def test_ses_callback_should_update_notification_status( def test_ses_callback_should_update_notification_status(
client, client,
notify_db, notify_db,
@@ -180,9 +170,6 @@ def test_ses_callback_should_not_set_status_once_status_is_delivered(client,
sent_at=datetime.utcnow() sent_at=datetime.utcnow()
) )
assert get_notification_by_id(notification.id).status == 'delivered'
error = process_ses_response(json.loads(ses_soft_bounce_callback()))
assert error == 'SES callback failed: notification either not found or already updated from sending. Status temporary-failure for notification reference ref' # noqa
assert get_notification_by_id(notification.id).status == 'delivered' assert get_notification_by_id(notification.id).status == 'delivered'
stats_mock.assert_not_called() stats_mock.assert_not_called()