darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 21:48:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Updates from review comments:

Browse Source 
Update api_key relationship.
Check that id in dict exists before deleting it
This commit is contained in:
Rebecca Law
2016-01-19 13:11:22 +00:00
parent 43d54b6ad3
commit 15b2d414cc
5 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/service/rest.py
View File

@@ -78,7 +78,7 @@ def get_service(service_id=None):
@service.route('/<int:service_id>/api-key/renew', methods=['POST'])
def renew_api_key(service_id=None):
try:
get_model_services(service_id=service_id)
service = get_model_services(service_id=service_id)
except DataError:
return jsonify(result="error", message="Invalid service id"), 400
except NoResultFound:
@@ -92,7 +92,7 @@ def renew_api_key(service_id=None):
# create a new one
# TODO: what validation should be done here?
secret_name = request.get_json()['name']
save_model_api_key(ApiKey(service_id=service_id, name=secret_name))
save_model_api_key(ApiKey(service=service, name=secret_name))
except DAOException as e:
return jsonify(result='error', message=str(e)), 400
unsigned_api_key = get_unsigned_secret(service_id)