darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update post_create_template_schema

Browse Source 
Updated the `post_create_template_schema` to check that the postage is
one of our allowed values.
This commit is contained in:
Katie Smith
2020-06-09 11:02:22 +01:00
parent 69043d70ec
commit 15112b2148
2 changed files with 36 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/app/template/test_rest.py
View File

@@ -778,6 +778,41 @@ def test_create_a_template_with_foreign_service_reply_to(admin_request, sample_u
)
@pytest.mark.parametrize('post_data, expected_errors', [
(
{},
[
{"error": "ValidationError", "message": "subject is a required property"},
{"error": "ValidationError", "message": "name is a required property"},
{"error": "ValidationError", "message": "template_type is a required property"},
{"error": "ValidationError", "message": "content is a required property"},
{"error": "ValidationError", "message": "service is a required property"},
{"error": "ValidationError", "message": "created_by is a required property"},
]
),
(
{"name": "my template", "template_type": "sms", "content": "hi", "postage": "third",
"service": "1af43c02-b5a8-4923-ad7f-5279b75ff2d0", "created_by": "30587644-9083-44d8-a114-98887f07f1e3"},
[
{"error": "ValidationError", "message": "postage invalid. It must be either first or second."},
]
),
])
def test_create_template_validates_against_json_schema(
admin_request,
sample_service_full_permissions,
post_data,
expected_errors,
):
response = admin_request.post(
'template.create_template',
service_id=sample_service_full_permissions.id,
_data=post_data,
_expected_status=400
)
assert response['errors'] == expected_errors
@pytest.mark.parametrize('template_default, service_default',
[('template address', 'service address'),
(None, 'service address'),