initial

notifications_utils/logging.py

@@ -161,5 +161,7 @@ class JSONFormatter(BaseJSONFormatter):
         try:
             log_record["message"] = log_record["message"].format(**log_record)
         except (KeyError, IndexError) as e:
-            logger.exception("failed to format log message: {} not found".format(e))
+            logger.exception(
+                "failed to format log message: {} not found".format(e), exc_info=True
+            )
         return log_record

notifications_utils/request_helper.py

@@ -81,11 +81,11 @@ class ResponseHeaderMiddleware(object):
             return self._app(environ, rewrite_response_headers)
         except BaseException as be:  # noqa
             if "AuthError" in str(be):  # notify-api-1135
-                current_app.logger.error(be)
+                current_app.logger.error("AuthError", exc_info=True)
             elif "AttributeError" in str(be):  # notify-api-1394
-                current_app.logger.error(be)
+                current_app.logger.error("AttributeError", exc_info=True)
             elif "MethodNotAllowed" in str(be):  # notify-admin-1392
-                current_app.logger.error(be)
+                current_app.logger.error("MethodNotAllowed", exc_info=True)
             else:
                 raise be
 

notifications_utils/s3.py

@@ -57,9 +57,7 @@ def s3upload(
     try:
         key.put(**put_args)
     except botocore.exceptions.ClientError as e:
-        current_app.logger.error(
-            "Unable to upload file to S3 bucket {}".format(bucket_name)
-        )
+        current_app.logger.error("Unable to upload file to S3 bucket", exc_info=True)
         raise e