darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 02:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Updated pytest for new return values

Browse Source
This commit is contained in:
Anastasia Gradova
2024-05-25 22:14:51 -06:00
parent 5fbad5bd69
commit 140e40ebe0
2 changed files with 33 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/app/service/test_statistics.py
View File

@@ -307,6 +307,7 @@ def test_add_monthly_notification_status_stats():
add_monthly_notification_status_stats(data, rows) add_monthly_notification_status_stats(data, rows)
# first 3 months are empty # first 3 months are empty
print("********* ", data)
assert data == { assert data == {
"2018-01": {NotificationType.SMS: {}, NotificationType.EMAIL: {}}, "2018-01": {NotificationType.SMS: {}, NotificationType.EMAIL: {}},
"2018-02": {NotificationType.SMS: {}, NotificationType.EMAIL: {}}, "2018-02": {NotificationType.SMS: {}, NotificationType.EMAIL: {}},
@@ -315,12 +316,22 @@ def test_add_monthly_notification_status_stats():
NotificationType.SMS: { NotificationType.SMS: {
NotificationStatus.SENDING: 1, NotificationStatus.SENDING: 1,
NotificationStatus.DELIVERED: 2, NotificationStatus.DELIVERED: 2,
StatisticsType.REQUESTED: 3,
},
NotificationType.EMAIL: {
NotificationStatus.SENDING: 4,
StatisticsType.REQUESTED: 4,
}, },
NotificationType.EMAIL: {NotificationStatus.SENDING: 4},
}, },
"2018-05": { "2018-05": {
NotificationType.SMS: {NotificationStatus.SENDING: 24}, NotificationType.SMS: {
NotificationType.EMAIL: {NotificationStatus.SENDING: 32}, NotificationStatus.SENDING: 24,
StatisticsType.REQUESTED: 8,
},
NotificationType.EMAIL: {
NotificationStatus.SENDING: 32,
StatisticsType.REQUESTED: 32,
},
}, },
"2018-06": {NotificationType.SMS: {}, NotificationType.EMAIL: {}}, "2018-06": {NotificationType.SMS: {}, NotificationType.EMAIL: {}},
} }

23
tests/app/service/test_statistics_rest.py
View File

@@ -255,7 +255,8 @@ def test_get_monthly_notification_stats_returns_stats(admin_request, sample_serv
assert response["data"]["2016-06"] == { assert response["data"]["2016-06"] == {
NotificationType.SMS: { NotificationType.SMS: {
# it combines the two days # it combines the two days
NotificationStatus.DELIVERED: 2 NotificationStatus.DELIVERED: 2,
StatisticsType.REQUESTED: 2,
}, },
NotificationType.EMAIL: {}, NotificationType.EMAIL: {},
} }
@@ -264,8 +265,12 @@ def test_get_monthly_notification_stats_returns_stats(admin_request, sample_serv
NotificationType.SMS: { NotificationType.SMS: {
NotificationStatus.CREATED: 1, NotificationStatus.CREATED: 1,
NotificationStatus.DELIVERED: 2, NotificationStatus.DELIVERED: 2,
StatisticsType.REQUESTED: 3,
},
NotificationType.EMAIL: {
StatisticsType.DELIVERED: 1,
StatisticsType.REQUESTED: 1,
}, },
NotificationType.EMAIL: {StatisticsType.DELIVERED: 1},
} }
@@ -311,7 +316,10 @@ def test_get_monthly_notification_stats_combines_todays_data_and_historic_stats(
assert len(response["data"]) == 6 # January to June assert len(response["data"]) == 6 # January to June
assert response["data"]["2016-05"] == { assert response["data"]["2016-05"] == {
NotificationType.SMS: {NotificationStatus.DELIVERED: 1}, NotificationType.SMS: {
NotificationStatus.DELIVERED: 1,
StatisticsType.REQUESTED: 1,
},
NotificationType.EMAIL: {}, NotificationType.EMAIL: {},
} }
assert response["data"]["2016-06"] == { assert response["data"]["2016-06"] == {
@@ -319,6 +327,7 @@ def test_get_monthly_notification_stats_combines_todays_data_and_historic_stats(
# combines the stats from the historic ft_notification_status and the current notifications # combines the stats from the historic ft_notification_status and the current notifications
NotificationStatus.CREATED: 3, NotificationStatus.CREATED: 3,
NotificationStatus.DELIVERED: 1, NotificationStatus.DELIVERED: 1,
StatisticsType.REQUESTED: 4,
}, },
NotificationType.EMAIL: {}, NotificationType.EMAIL: {},
} }
@@ -354,6 +363,7 @@ def test_get_monthly_notification_stats_ignores_test_keys(
assert response["data"]["2016-06"][NotificationType.SMS] == { assert response["data"]["2016-06"][NotificationType.SMS] == {
NotificationStatus.DELIVERED: 3, NotificationStatus.DELIVERED: 3,
StatisticsType.REQUESTED: 3,
} }
@@ -385,9 +395,11 @@ def test_get_monthly_notification_stats_checks_dates(admin_request, sample_servi
assert "2017-04" not in response["data"] assert "2017-04" not in response["data"]
assert response["data"]["2016-04"][NotificationType.SMS] == { assert response["data"]["2016-04"][NotificationType.SMS] == {
NotificationStatus.SENDING: 1, NotificationStatus.SENDING: 1,
StatisticsType.REQUESTED: 1,
} }
assert response["data"]["2016-04"][NotificationType.SMS] == { assert response["data"]["2016-04"][NotificationType.SMS] == {
NotificationStatus.SENDING: 1, NotificationStatus.SENDING: 1,
StatisticsType.REQUESTED: 1,
} }
@@ -416,6 +428,9 @@ def test_get_monthly_notification_stats_only_gets_for_one_service(
) )
assert response["data"]["2016-06"] == { assert response["data"]["2016-06"] == {
NotificationType.SMS: {NotificationStatus.CREATED: 1}, NotificationType.SMS: {
NotificationStatus.CREATED: 1,
StatisticsType.REQUESTED: 1,
},
NotificationType.EMAIL: {}, NotificationType.EMAIL: {},
} }