Refactor schema to improve error response

This commit is contained in:
Ken Tsang
2017-05-25 17:45:15 +01:00
parent 54d85fd8df
commit 1375bbe400
4 changed files with 12 additions and 15 deletions

View File

@@ -130,10 +130,7 @@ def update_service(service_id):
current_data = dict(service_schema.dump(fetched_service).data.items())
service_schema.set_override_flag(request.get_json().get('permissions') is not None)
current_data.update(request.get_json())
try:
update_dict = service_schema.load(current_data).data
except ValueError as e:
raise InvalidRequest(str(e), status_code=400)
update_dict = service_schema.load(current_data).data
dao_update_service(update_dict)
if service_going_live: