darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 23:41:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't log address redaction failure when letter sent with test key

Browse Source
This commit is contained in:
Pea Tyczynska
2019-09-17 15:55:26 +01:00
parent 99eb17fc29
commit 1279a46b8b
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/letters_pdf_tasks.py
View File

@@ -228,7 +228,7 @@ def process_virus_scan_passed(self, filename):
new_pdf = sanitise_response.content new_pdf = sanitise_response.content
redaction_failed_message = sanitise_response.get("redaction_failed_message") redaction_failed_message = sanitise_response.get("redaction_failed_message")
if redaction_failed_message: if redaction_failed_message and not is_test_key:
current_app.logger.info('{} for notification id {} ({})'.format( current_app.logger.info('{} for notification id {} ({})'.format(
redaction_failed_message, notification.id, filename) redaction_failed_message, notification.id, filename)
) )

3
tests/app/celery/test_letters_pdf_tasks.py
View File

@@ -532,10 +532,13 @@ def test_process_letter_task_check_virus_scan_passed_when_redaction_fails(
assert sample_letter_notification.billable_units == 2 assert sample_letter_notification.billable_units == 2
assert sample_letter_notification.status == notification_status assert sample_letter_notification.status == notification_status
if key_type == KEY_TYPE_NORMAL:
mock_copy_s3.assert_called_once_with( mock_copy_s3.assert_called_once_with(
bucket_name, filename, bucket_name, filename,
bucket_name, 'REDACTION_FAILURE/' + filename bucket_name, 'REDACTION_FAILURE/' + filename
) )
else:
mock_copy_s3.assert_not_called()
@freeze_time('2018-01-01 18:00') @freeze_time('2018-01-01 18:00')