darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-04 13:40:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2425 from alphagov/remove-inbound-get

Browse Source 
remove get for inbound sms by phone number
This commit is contained in:
Leo Hemsted
2019-04-01 16:43:06 +01:00
committed by GitHub
parent 020eb76f73 68aaf1e877
commit 1250e47cc7
2 changed files with 8 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/inbound_sms/rest.py
View File

@@ -28,17 +28,10 @@ register_errors(inbound_sms)
@inbound_sms.route('', methods=['POST'])
def post_query_inbound_sms_for_service(service_id):
def post_inbound_sms_for_service(service_id):
form = validate(request.get_json(), get_inbound_sms_for_service_schema)
return _get_inbound_sms(service_id, user_number=form.get('phone_number'))
user_number = form.get('phone_number')
@inbound_sms.route('', methods=['GET'])
def get_inbound_sms_for_service(service_id):
return _get_inbound_sms(service_id, user_number=request.args.get('user_number'))
def _get_inbound_sms(service_id, user_number):
if user_number:
# we use this to normalise to an international phone number - but this may fail if it's an alphanumeric
user_number = try_validate_and_format_phone_number(user_number, international=True)