Refactor to increase readability for getting whitelist objects

This commit is contained in:
Imdad Ahad
2016-09-28 10:16:10 +01:00
parent f9b539d71e
commit 1222a6ddf3
2 changed files with 25 additions and 14 deletions

17
app/service/utils.py Normal file
View File

@@ -0,0 +1,17 @@
from app.models import (
ServiceWhitelist,
MOBILE_TYPE, EMAIL_TYPE)
def get_recipients_from_request(request_json, key, type):
return [(type, recipient) for recipient in request_json.get(key)]
def get_whitelist_objects(service_id, request_json):
return [
ServiceWhitelist.from_string(service_id, type, recipient)
for type, recipient in (
get_recipients_from_request(request_json, 'phone_numbers', MOBILE_TYPE) +
get_recipients_from_request(request_json, 'email_addresses', EMAIL_TYPE)
)
]