From 0f470af7b6db44e823f3ab8db3d1d2e595da7d2a Mon Sep 17 00:00:00 2001 From: Kenneth Kehl <@kkehl@flexion.us> Date: Mon, 22 May 2023 11:35:00 -0700 Subject: [PATCH] fix more skips --- tests/app/dao/test_services_dao.py | 2 -- tests/app/user/test_rest_verify.py | 1 - tests/app/v2/notifications/test_post_notifications.py | 3 +-- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/app/dao/test_services_dao.py b/tests/app/dao/test_services_dao.py index a7017db27..405035cc0 100644 --- a/tests/app/dao/test_services_dao.py +++ b/tests/app/dao/test_services_dao.py @@ -586,7 +586,6 @@ def test_update_service_permission_creates_a_history_record_with_current_data(no assert history[2].version == 3 -# @pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason") def test_create_service_and_history_is_transactional(notify_db_session): user = create_user() assert Service.query.count() == 0 @@ -828,7 +827,6 @@ def test_dao_fetch_todays_stats_for_service_only_includes_today_during_bst(notif assert not stats.get('permanent-failure') -# @pytest.mark.skip(reason="Need a better way to test variable DST date") def test_dao_fetch_todays_stats_for_service_only_includes_today_when_clocks_fall_back(notify_db_session): template = create_template(service=create_service()) with freeze_time('2021-10-30T22:59:59'): diff --git a/tests/app/user/test_rest_verify.py b/tests/app/user/test_rest_verify.py index 42bd03cbf..f2d38002f 100644 --- a/tests/app/user/test_rest_verify.py +++ b/tests/app/user/test_rest_verify.py @@ -386,7 +386,6 @@ def test_reset_failed_login_count_returns_404_when_user_does_not_exist(client): assert resp.status_code == 404 -@pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason") # we send sms_auth users and webauthn_auth users email code to validate their email access @pytest.mark.parametrize('auth_type', USER_AUTH_TYPES) @pytest.mark.parametrize('data, expected_auth_url', ( diff --git a/tests/app/v2/notifications/test_post_notifications.py b/tests/app/v2/notifications/test_post_notifications.py index bb011ecd8..adcadc24a 100644 --- a/tests/app/v2/notifications/test_post_notifications.py +++ b/tests/app/v2/notifications/test_post_notifications.py @@ -288,7 +288,6 @@ def test_should_cache_template_and_service_in_redis(mocker, client, sample_templ assert templates_call[1]['ex'] == 604_800 -@pytest.mark.skip(reason="Needs updating for TTS: cloud.gov redis fails, local docker works, mock redis fails") def test_should_return_template_if_found_in_redis(mocker, client, sample_template): from app.schemas import service_schema, template_schema @@ -312,7 +311,7 @@ def test_should_return_template_if_found_in_redis(mocker, client, sample_templat mocker.patch('app.celery.provider_tasks.deliver_sms.apply_async') data = { - 'phone_number': '+447700900855', + 'phone_number': '+16615555555', 'template_id': str(sample_template.id), }