darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-05-04 00:00:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Kenneth Kehl
2024-04-12 09:23:22 -07:00
parent 906609e4de
commit 0f3cdcf56a
14 changed files with 93 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/app/user/test_rest.py
View File

@@ -237,7 +237,7 @@ def test_cannot_create_user_with_empty_strings(admin_request, notify_db_session)
[
("name", "New User"),
("email_address", "newuser@mail.com"),
("mobile_number", "+4407700900460"),
("mobile_number", "+14254147755"),
],
)
def test_post_user_attribute(admin_request, sample_user, user_attribute, user_value):
@@ -273,13 +273,13 @@ def test_post_user_attribute(admin_request, sample_user, user_attribute, user_va
),
(
"mobile_number",
"+4407700900460",
"+14254147755",
dict(
api_key_id=None,
key_type=KeyType.NORMAL,
notification_type=NotificationType.SMS,
personalisation={},
recipient="+4407700900460",
recipient="+14254147755",
reply_to_text="testing",
service=mock.ANY,
template_id=uuid.UUID("8a31520f-4751-4789-8ea1-fe54496725eb"),
@@ -315,6 +315,7 @@ def test_post_user_attribute_with_updated_by(
mock_persist_notification.assert_not_called()
@pytest.mark.skip("We don't support international at the moment")
def test_post_user_attribute_with_updated_by_sends_notification_to_international_from_number(
admin_request, mocker, sample_user, team_member_mobile_edit_template
):

3
tests/app/user/test_rest_verify.py
View File

@@ -245,7 +245,7 @@ def test_send_user_code_for_sms_with_optional_to_field(
mock_redis_get.return_value = "foo"
mocker.patch("app.user.rest.redis_store.raw_set")
to_number = "+447119876757"
to_number = "+14254147755"
mocked = mocker.patch("app.user.rest.create_secret_code", return_value="11111")
mocker.patch("app.celery.provider_tasks.deliver_sms.apply_async")
auth_header = create_admin_authorization_header()
@@ -581,6 +581,7 @@ def test_user_verify_email_code_fails_if_code_already_used(
assert sample_user.current_session_id is None
@pytest.mark.skip("We don't support international at the moment")
def test_send_user_2fa_code_sends_from_number_for_international_numbers(
client, sample_user, mocker, sms_code_template
):