darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-21 07:51:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1084 from alphagov/add-logging-to-sms-drs

Browse Source 
Add logging to SMS delivery receipts
This commit is contained in:
Rebecca Law
2017-07-21 12:29:45 +01:00
committed by GitHub
parent cfbf7ba2d1 301339e689
commit 0e3d84c91c
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/notifications/notifications_sms_callback.py
View File

@@ -1,4 +1,5 @@
from flask import Blueprint from flask import Blueprint
from flask import current_app
from flask import json from flask import json
from flask import request, jsonify from flask import request, jsonify
@@ -22,6 +23,12 @@ def process_mmg_response():
success, errors = process_sms_client_response(status=str(data.get('status')), success, errors = process_sms_client_response(status=str(data.get('status')),
reference=data.get('CID'), reference=data.get('CID'),
client_name=client_name) client_name=client_name)
safe_to_log = data.copy()
safe_to_log.pop("MSISDN")
current_app.logger.info(
"Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('CID'),
safe_to_log))
if errors: if errors:
raise InvalidRequest(errors, status_code=400) raise InvalidRequest(errors, status_code=400)
else: else:
@@ -36,9 +43,12 @@ def process_firetext_response():
client_name=client_name) client_name=client_name)
if errors: if errors:
raise InvalidRequest(errors, status_code=400) raise InvalidRequest(errors, status_code=400)
safe_to_log = dict(request.form).copy()
status = request.form.get('status') safe_to_log.pop('mobile')
success, errors = process_sms_client_response(status=status, current_app.logger.info(
"Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('reference'),
safe_to_log))
success, errors = process_sms_client_response(status=request.form.get('status'),
reference=request.form.get('reference'), reference=request.form.get('reference'),
client_name=client_name) client_name=client_name)
if errors: if errors: