darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-21 07:51:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3252 from alphagov/upgrade-warning-to-error

Browse Source 
Add a error log for alert tasks.
This commit is contained in:
Rebecca Law
2021-06-02 13:48:01 +01:00
committed by GitHub
parent 3159334907 1bf5ce08b2
commit 0e0c911517
3 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/celery/broadcast_message_tasks.py
View File

@@ -150,6 +150,7 @@ def send_broadcast_event(broadcast_event_id):
ticket_type=zendesk_client.TYPE_INCIDENT, ticket_type=zendesk_client.TYPE_INCIDENT,
p1=True, p1=True,
) )
current_app.logger.error(message)
for provider in broadcast_event.service.get_available_broadcast_providers(): for provider in broadcast_event.service.get_available_broadcast_providers():
send_broadcast_provider_message.apply_async( send_broadcast_provider_message.apply_async(

6
app/celery/scheduled_tasks.py
View File

@@ -211,14 +211,13 @@ def check_if_letters_still_pending_virus_check():
https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#Deal-with-letter-pending-virus-scan-for-90-minutes. https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#Deal-with-letter-pending-virus-scan-for-90-minutes.
Notifications: {}""".format(len(letters), sorted(letter_ids)) Notifications: {}""".format(len(letters), sorted(letter_ids))
current_app.logger.warning(msg)
if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']: if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']:
zendesk_client.create_ticket( zendesk_client.create_ticket(
subject="[{}] Letters still pending virus check".format(current_app.config['NOTIFY_ENVIRONMENT']), subject="[{}] Letters still pending virus check".format(current_app.config['NOTIFY_ENVIRONMENT']),
message=msg, message=msg,
ticket_type=zendesk_client.TYPE_INCIDENT ticket_type=zendesk_client.TYPE_INCIDENT
) )
current_app.logger.error(msg)
@notify_celery.task(name='check-if-letters-still-in-created') @notify_celery.task(name='check-if-letters-still-in-created')
@@ -231,14 +230,13 @@ def check_if_letters_still_in_created():
"https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook" \ "https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook" \
"#deal-with-Letters-still-in-created.".format(len(letters)) "#deal-with-Letters-still-in-created.".format(len(letters))
current_app.logger.warning(msg)
if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']: if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']:
zendesk_client.create_ticket( zendesk_client.create_ticket(
subject="[{}] Letters still in 'created' status".format(current_app.config['NOTIFY_ENVIRONMENT']), subject="[{}] Letters still in 'created' status".format(current_app.config['NOTIFY_ENVIRONMENT']),
message=msg, message=msg,
ticket_type=zendesk_client.TYPE_INCIDENT ticket_type=zendesk_client.TYPE_INCIDENT
) )
current_app.logger.error(msg)
@notify_celery.task(name='check-for-missing-rows-in-completed-jobs') @notify_celery.task(name='check-for-missing-rows-in-completed-jobs')

6
tests/app/celery/test_scheduled_tasks.py
View File

@@ -356,7 +356,7 @@ def test_check_job_status_task_does_not_raise_error(sample_template):
@freeze_time("2019-05-30 14:00:00") @freeze_time("2019-05-30 14:00:00")
def test_check_if_letters_still_pending_virus_check(mocker, sample_letter_template): def test_check_if_letters_still_pending_virus_check(mocker, sample_letter_template):
mock_logger = mocker.patch('app.celery.tasks.current_app.logger.warning') mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error')
mock_create_ticket = mocker.patch('app.celery.nightly_tasks.zendesk_client.create_ticket') mock_create_ticket = mocker.patch('app.celery.nightly_tasks.zendesk_client.create_ticket')
create_notification(template=sample_letter_template, create_notification(template=sample_letter_template,
@@ -393,7 +393,7 @@ def test_check_if_letters_still_pending_virus_check(mocker, sample_letter_templa
@freeze_time("2019-05-30 14:00:00") @freeze_time("2019-05-30 14:00:00")
def test_check_if_letters_still_in_created_during_bst(mocker, sample_letter_template): def test_check_if_letters_still_in_created_during_bst(mocker, sample_letter_template):
mock_logger = mocker.patch('app.celery.tasks.current_app.logger.warning') mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error')
mock_create_ticket = mocker.patch('app.celery.nightly_tasks.zendesk_client.create_ticket') mock_create_ticket = mocker.patch('app.celery.nightly_tasks.zendesk_client.create_ticket')
create_notification(template=sample_letter_template, created_at=datetime(2019, 5, 1, 12, 0)) create_notification(template=sample_letter_template, created_at=datetime(2019, 5, 1, 12, 0))
@@ -419,7 +419,7 @@ def test_check_if_letters_still_in_created_during_bst(mocker, sample_letter_temp
@freeze_time("2019-01-30 14:00:00") @freeze_time("2019-01-30 14:00:00")
def test_check_if_letters_still_in_created_during_utc(mocker, sample_letter_template): def test_check_if_letters_still_in_created_during_utc(mocker, sample_letter_template):
mock_logger = mocker.patch('app.celery.tasks.current_app.logger.warning') mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error')
mock_create_ticket = mocker.patch('app.celery.scheduled_tasks.zendesk_client.create_ticket') mock_create_ticket = mocker.patch('app.celery.scheduled_tasks.zendesk_client.create_ticket')
create_notification(template=sample_letter_template, created_at=datetime(2018, 12, 1, 12, 0)) create_notification(template=sample_letter_template, created_at=datetime(2018, 12, 1, 12, 0))