darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-05 10:42:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don’t return letter contact blocks in service JSON

Browse Source 
The admin app doesn’t use them:
https://github.com/alphagov/notifications-admin/search?q=letter_contact_block&unscoped_q=letter_contact_block

Instead it requests them separately when needed:
2f1e8b104b/app/models/service.py (L349-L351)

Removing this from the response means one fewer database query.
This commit is contained in:
Chris Hill-Scott
2020-06-22 09:51:59 +01:00
parent dcc407efea
commit 0d2060fcfa
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/schemas.py
View File

@@ -205,7 +205,6 @@ class ServiceSchema(BaseSchema):
email_branding = field_for(models.Service, 'email_branding') email_branding = field_for(models.Service, 'email_branding')
organisation = field_for(models.Service, 'organisation') organisation = field_for(models.Service, 'organisation')
override_flag = False override_flag = False
letter_contact_block = fields.Method(serialize="get_letter_contact")
go_live_at = field_for(models.Service, 'go_live_at', format=DATETIME_FORMAT_NO_TIMEZONE) go_live_at = field_for(models.Service, 'go_live_at', format=DATETIME_FORMAT_NO_TIMEZONE)
def get_letter_logo_filename(self, service): def get_letter_logo_filename(self, service):
@@ -219,7 +218,6 @@ class ServiceSchema(BaseSchema):
class Meta: class Meta:
model = models.Service model = models.Service
dump_only = ['letter_contact_block']
exclude = ( exclude = (
'updated_at', 'updated_at',
'created_at', 'created_at',