darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 18:01:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Bump utils to 39.0.0

Browse Source 
`allow_international_letters` is a new, required argument, so the tests
that make some `Row` objects need to provide that.

There are now 8 possible address columns (7 plus postcode) so the tests
need to expect that. But this won’t have any user-facing impact.
This commit is contained in:
Chris Hill-Scott
2020-04-29 15:51:02 +01:00
parent ba0d330593
commit 0c1373eeb5
3 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
requirements-app.txt
View File

@@ -26,6 +26,6 @@ notifications-python-client==5.5.1
# PaaS # PaaS
awscli-cwlogs>=1.4,<1.5 awscli-cwlogs>=1.4,<1.5
git+https://github.com/alphagov/notifications-utils.git@38.1.0#egg=notifications-utils==38.1.0 git+https://github.com/alphagov/notifications-utils.git@39.0.0#egg=notifications-utils==39.0.0
gds-metrics==0.2.0 gds-metrics==0.2.0

10
requirements.txt
View File

@@ -28,7 +28,7 @@ notifications-python-client==5.5.1
# PaaS # PaaS
awscli-cwlogs>=1.4,<1.5 awscli-cwlogs>=1.4,<1.5
git+https://github.com/alphagov/notifications-utils.git@38.0.0#egg=notifications-utils==38.0.0 git+https://github.com/alphagov/notifications-utils.git@39.0.0#egg=notifications-utils==39.0.0
gds-metrics==0.2.0 gds-metrics==0.2.0
@@ -37,17 +37,17 @@ alembic==1.4.2
amqp==1.4.9 amqp==1.4.9
anyjson==0.3.3 anyjson==0.3.3
attrs==19.3.0 attrs==19.3.0
awscli==1.18.46 awscli==1.18.48
bcrypt==3.1.7 bcrypt==3.1.7
billiard==3.3.0.23 billiard==3.3.0.23
bleach==3.1.4 bleach==3.1.4
blinker==1.4 blinker==1.4
boto==2.49.0 boto==2.49.0
boto3==1.10.38 boto3==1.10.38
botocore==1.15.46 botocore==1.15.48
certifi==2020.4.5.1 certifi==2020.4.5.1
chardet==3.0.4 chardet==3.0.4
click==7.1.1 click==7.1.2
colorama==0.4.3 colorama==0.4.3
dnspython==1.16.0 dnspython==1.16.0
docutils==0.15.2 docutils==0.15.2
@@ -74,7 +74,7 @@ pyrsistent==0.16.0
python-dateutil==2.8.1 python-dateutil==2.8.1
python-editor==1.0.4 python-editor==1.0.4
python-json-logger==0.1.11 python-json-logger==0.1.11
pytz==2019.3 pytz==2020.1
PyYAML==5.3.1 PyYAML==5.3.1
redis==3.4.1 redis==3.4.1
requests==2.23.0 requests==2.23.0

5
tests/app/celery/test_tasks.py
View File

@@ -340,7 +340,7 @@ def test_should_process_letter_job(sample_letter_job, mocker):
row_call = process_row_mock.mock_calls[0][1] row_call = process_row_mock.mock_calls[0][1]
assert row_call[0].index == 0 assert row_call[0].index == 0
assert row_call[0].recipient == ['A1', 'A2', 'A3', 'A4', None, None, 'A_POST'] assert row_call[0].recipient == ['A1', 'A2', 'A3', 'A4', None, None, 'A_POST', None]
assert row_call[0].personalisation == { assert row_call[0].personalisation == {
'addressline1': 'A1', 'addressline1': 'A1',
'addressline2': 'A2', 'addressline2': 'A2',
@@ -407,6 +407,7 @@ def test_process_row_sends_letter_task(template_type, research_mode, expected_fu
recipient_column_headers=['to'], recipient_column_headers=['to'],
placeholders={'foo'}, placeholders={'foo'},
template=template, template=template,
allow_international_letters=True,
), ),
template, template,
job, job,
@@ -449,6 +450,7 @@ def test_process_row_when_sender_id_is_provided(mocker, fake_uuid):
recipient_column_headers=['to'], recipient_column_headers=['to'],
placeholders={'foo'}, placeholders={'foo'},
template=template, template=template,
allow_international_letters=True,
), ),
template, template,
job, job,
@@ -1418,6 +1420,7 @@ def test_get_letter_template_instance(mocker, sample_job):
'address line 5', 'address line 5',
'address line 6', 'address line 6',
'postcode', 'postcode',
'address line 7',
] ]