darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-25 08:43:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update how "letters still created status" Zendesk tickets are created

Browse Source
This commit is contained in:
Katie Smith
2021-09-23 16:22:07 +01:00
parent 2f66e38fb9
commit 0c0c7f4478
2 changed files with 27 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/celery/scheduled_tasks.py
View File

@@ -239,11 +239,14 @@ def check_if_letters_still_in_created():
"#deal-with-Letters-still-in-created.".format(len(letters)) "#deal-with-Letters-still-in-created.".format(len(letters))
if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']: if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']:
zendesk_client.create_ticket( ticket = NotifySupportTicket(
subject="[{}] Letters still in 'created' status".format(current_app.config['NOTIFY_ENVIRONMENT']), subject=f"[{current_app.config['NOTIFY_ENVIRONMENT']}] Letters still in 'created' status",
message=msg, message=msg,
ticket_type=zendesk_client.TYPE_INCIDENT ticket_type=NotifySupportTicket.TYPE_INCIDENT,
technical_ticket=True,
ticket_categories=['notify_letters']
) )
zendesk_client.send_ticket_to_zendesk(ticket)
current_app.logger.error(msg) current_app.logger.error(msg)

26
tests/app/celery/test_scheduled_tasks.py
View File

@@ -412,7 +412,11 @@ def test_check_if_letters_still_pending_virus_check(mocker, sample_letter_templa
@freeze_time("2019-05-30 14:00:00") @freeze_time("2019-05-30 14:00:00")
def test_check_if_letters_still_in_created_during_bst(mocker, sample_letter_template): def test_check_if_letters_still_in_created_during_bst(mocker, sample_letter_template):
mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error') mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error')
mock_create_ticket = mocker.patch('app.celery.nightly_tasks.zendesk_client.create_ticket') mock_create_ticket = mocker.spy(NotifySupportTicket, '__init__')
mock_send_ticket_to_zendesk = mocker.patch(
'app.celery.scheduled_tasks.zendesk_client.send_ticket_to_zendesk',
autospec=True,
)
create_notification(template=sample_letter_template, created_at=datetime(2019, 5, 1, 12, 0)) create_notification(template=sample_letter_template, created_at=datetime(2019, 5, 1, 12, 0))
create_notification(template=sample_letter_template, created_at=datetime(2019, 5, 29, 16, 29)) create_notification(template=sample_letter_template, created_at=datetime(2019, 5, 29, 16, 29))
@@ -429,16 +433,24 @@ def test_check_if_letters_still_in_created_during_bst(mocker, sample_letter_temp
mock_logger.assert_called_once_with(message) mock_logger.assert_called_once_with(message)
mock_create_ticket.assert_called_with( mock_create_ticket.assert_called_with(
ANY,
message=message, message=message,
subject="[test] Letters still in 'created' status", subject="[test] Letters still in 'created' status",
ticket_type='incident' ticket_type='incident',
technical_ticket=True,
ticket_categories=['notify_letters']
) )
mock_send_ticket_to_zendesk.assert_called_once()
@freeze_time("2019-01-30 14:00:00") @freeze_time("2019-01-30 14:00:00")
def test_check_if_letters_still_in_created_during_utc(mocker, sample_letter_template): def test_check_if_letters_still_in_created_during_utc(mocker, sample_letter_template):
mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error') mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error')
mock_create_ticket = mocker.patch('app.celery.scheduled_tasks.zendesk_client.create_ticket') mock_create_ticket = mocker.spy(NotifySupportTicket, '__init__')
mock_send_ticket_to_zendesk = mocker.patch(
'app.celery.scheduled_tasks.zendesk_client.send_ticket_to_zendesk',
autospec=True,
)
create_notification(template=sample_letter_template, created_at=datetime(2018, 12, 1, 12, 0)) create_notification(template=sample_letter_template, created_at=datetime(2018, 12, 1, 12, 0))
create_notification(template=sample_letter_template, created_at=datetime(2019, 1, 29, 17, 29)) create_notification(template=sample_letter_template, created_at=datetime(2019, 1, 29, 17, 29))
@@ -454,11 +466,15 @@ def test_check_if_letters_still_in_created_during_utc(mocker, sample_letter_temp
"https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#deal-with-Letters-still-in-created." "https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#deal-with-Letters-still-in-created."
mock_logger.assert_called_once_with(message) mock_logger.assert_called_once_with(message)
mock_create_ticket.assert_called_with( mock_create_ticket.assert_called_once_with(
ANY,
message=message, message=message,
subject="[test] Letters still in 'created' status", subject="[test] Letters still in 'created' status",
ticket_type='incident' ticket_type='incident',
technical_ticket=True,
ticket_categories=['notify_letters']
) )
mock_send_ticket_to_zendesk.assert_called_once()
@pytest.mark.parametrize('offset', ( @pytest.mark.parametrize('offset', (