darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 23:26:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2024-10-29 13:30:41 -07:00
parent 600e5938fe
commit 0b7079edd9
1 changed files with 1 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/app/upload/test_upload_rest.py
View File

@@ -4,7 +4,6 @@ from unittest.mock import MagicMock
from app.upload.rest import get_paginated_uploads
# TODO
def test_get_paginated_uploads(mocker):
mock_current_app = mocker.patch("app.upload.rest.current_app")
mock_dao_get_uploads = mocker.patch("app.upload.rest.dao_get_uploads_by_service_id")
@@ -56,48 +55,15 @@ def test_get_paginated_uploads(mocker):
MagicMock(status="delivered", count=60),
]
mock_pagination_links.return_value = {"self": "/uploads?page=1"}
# result =
get_paginated_uploads("service_id_123", limit_days=7, page=1)
mock_dao_get_uploads.assert_called_once_with(
"service_id_123", limit_days=7, page=1, page_size=10
)
mock_midnight_n_days_ago.assert_called_once_with(3)
# mock_fetch_notification_statuses.assert_called_once_with("upload_1")
mock_dao_get_notification_outcomes.assert_called_once_with(
"service_id_123", "upload_1"
)
mock_pagination_links.assert_called_once_with(
mock_pagination, ".get_uploads_by_service", service_id="service_id_123"
)
# expected_data = {
# "data": [
# {
# "id": "upload_1",
# "original_file_name": "file1.csv",
# "notification_count": 100,
# "created_at": "2024-10-01 12:00:00",
# "upload_type": "job",
# "template_type": "sms",
# "recipient": "recipient@example.com",
# "statistics": [
# {"status": "delivered", "count": 90},
# {"status": "failed", "count": 10},
# ],
# },
# {
# "id": "upload_2",
# "original_file_name": "file2.csv",
# "notification_count": 50,
# "created_at": "2024-10-03 12:00:00",
# "upload_type": "letter",
# "template_type": "letter",
# "recipient": "recipient2@example.com",
# "statistics": [],
# },
# ],
# "page_size": 10,
# "total": 2,
# "links": {"self": "/uploads?page=1"},
# }
# assert result == expected_data