darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 09:26:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactored to make code clearer

Browse Source
This commit is contained in:
Ken Tsang
2017-06-29 18:02:21 +01:00
committed by venusbb
parent e0fbcb0dc6
commit 0b3277b8a4
6 changed files with 47 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/v2/notifications/post_notifications.py
View File

@@ -15,12 +15,14 @@ from app.notifications.validators import (
validate_template
)
from app.schema_validation import validate
from app.utils import get_public_notify_type_text
from app.v2.notifications import v2_notification_blueprint
from app.v2.notifications.notification_schemas import (
post_sms_request,
create_post_sms_response_from_notification,
post_email_request,
create_post_email_response_from_notification)
from app.v2.errors import BadRequestError
@v2_notification_blueprint.route('/<notification_type>', methods=['POST'])
@@ -30,11 +32,14 @@ def post_notification(notification_type):
else:
form = validate(request.get_json(), post_sms_request)
service_has_permission(authenticated_service, notification_type)
if service_has_permission(notification_type, authenticated_service.permissions) is False:
raise BadRequestError(message="Cannot send {}".format(
get_public_notify_type_text(notification_type, plural=True)))
scheduled_for = form.get("scheduled_for", None)
if scheduled_for:
service_has_permission(authenticated_service, SCHEDULE_NOTIFICATIONS)
if service_has_permission(SCHEDULE_NOTIFICATIONS, authenticated_service.permissions) is False:
raise BadRequestError(message="Cannot schedule notifications (this feature is invite-only)")
check_rate_limiting(authenticated_service, api_user)