darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-02 04:38:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactored to make code clearer

Browse Source
This commit is contained in:
Ken Tsang
2017-06-29 18:02:21 +01:00
committed by venusbb
parent e0fbcb0dc6
commit 0b3277b8a4
6 changed files with 47 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/notifications/validators.py
View File

@@ -73,17 +73,8 @@ def service_can_send_to_recipient(send_to, key_type, service):
raise BadRequestError(message=message)
def service_has_permission(service, permission):
if permission not in [p.permission for p in service.permissions]:
action = 'send'
permission_text = permission + 's'
if permission == SMS_TYPE:
permission_text = 'text messages'
elif permission == SCHEDULE_NOTIFICATIONS:
action = 'schedule'
permission_text = "notifications (this feature is invite-only)"
raise BadRequestError(message="Cannot {} {}".format(action, permission_text))
def service_has_permission(notify_type, permissions):
return notify_type in [p.permission for p in permissions]
def validate_and_format_recipient(send_to, key_type, service, notification_type):