darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 17:01:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

use server_default in alembic to ensure zero-downtimeness

Browse Source 
we can back-fill data, however, between alembic running and the api
updating to the new code, it'll still try and create new users without
adding the auth_type, because that won't be referenced in the model yet.

Instead of using a python-level default, a postgres-level
server_default will make postgres set every row to sms_auth if it's not
defined in the application.
This commit is contained in:
Leo Hemsted
2017-10-30 11:17:46 +00:00
parent 6acea8323b
commit 0ab89116ee
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
migrations/versions/0131_user_auth_types.py
View File

@@ -21,16 +21,12 @@ def upgrade():
)
op.execute("INSERT INTO auth_type VALUES ('email_auth'), ('sms_auth')")
op.add_column('users', sa.Column('auth_type', sa.String(), nullable=True))
op.execute("UPDATE users SET auth_type='sms_auth'")
op.alter_column('users', 'auth_type', nullable=False)
op.add_column('users', sa.Column('auth_type', sa.String(), nullable=False, server_default='sms_auth'))
op.create_index(op.f('ix_users_auth_type'), 'users', ['auth_type'], unique=False)
op.create_foreign_key(None, 'users', 'auth_type', ['auth_type'], ['name'])
op.add_column('invited_users', sa.Column('auth_type', sa.String(), nullable=True))
op.execute("UPDATE invited_users SET auth_type='sms_auth'")
op.alter_column('invited_users', 'auth_type', nullable=False)
op.add_column('invited_users', sa.Column('auth_type', sa.String(), nullable=False, server_default='sms_auth'))
op.create_index(op.f('ix_invited_users_auth_type'), 'invited_users', ['auth_type'], unique=False)
op.create_foreign_key(None, 'invited_users', 'auth_type', ['auth_type'], ['name'])