darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 08:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Small refactor to how notification_schemas are tested.

Browse Source 
My local build was not always getting the optional requirement for the jsonschema uri format checker (rfc3987).
The requirement has been added to the requirements_for_test file.
I changed the tests to validate the response schema from the post_notifications tests, this way we can tell if we are breaking the contract.
This showed that the email_from was not returning the entire email address but just the username, that has been corrected here.
Removed the response schema validation tests since they are not being testing in the post notification tests.
This commit is contained in:
Rebecca Law
2017-09-11 11:10:45 +01:00
parent 3309325cd3
commit 0a21f1f3e8
6 changed files with 16 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/v2/notifications/notification_schemas.py
View File

@@ -177,7 +177,7 @@ email_content = {
post_email_response = {
"$schema": "http://json-schema.org/draft-04/schema#",
"description": "POST sms notification response schema",
"description": "POST email notification response schema",
"type": "object",
"title": "response v2/notifications/email",
"properties": {