darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 14:08:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't test whether deleting service doesn't delete service permission

Browse Source 
types. As we found it unncessarry.
This commit is contained in:
Pea Tyczynska
2019-02-12 12:25:56 +00:00
parent 6320882876
commit 08663b386c
1 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/app/dao/test_services_dao.py
View File

@@ -45,7 +45,6 @@ from app.models import (
InvitedUser, InvitedUser,
Service, Service,
ServicePermission, ServicePermission,
ServicePermissionTypes,
DVLA_ORG_HM_GOVERNMENT, DVLA_ORG_HM_GOVERNMENT,
KEY_TYPE_NORMAL, KEY_TYPE_NORMAL,
KEY_TYPE_TEAM, KEY_TYPE_TEAM,
@@ -54,8 +53,7 @@ from app.models import (
EMAIL_TYPE, EMAIL_TYPE,
SMS_TYPE, SMS_TYPE,
INTERNATIONAL_SMS_TYPE, INTERNATIONAL_SMS_TYPE,
LETTER_TYPE, LETTER_TYPE
SERVICE_PERMISSION_TYPES
) )
from tests.app.db import ( from tests.app.db import (
create_inbound_number, create_inbound_number,
@@ -330,15 +328,6 @@ def test_removing_all_permission_returns_service_with_no_permissions(notify_db_s
assert len(service.permissions) == 0 assert len(service.permissions) == 0
def test_remove_service_does_not_remove_service_permission_types(notify_db_session):
service = create_service()
delete_service_and_all_associated_db_objects(service)
services = dao_fetch_all_services()
assert len(services) == 0
assert set(p.name for p in ServicePermissionTypes.query.all()) == set(SERVICE_PERMISSION_TYPES)
def test_create_service_by_id_adding_and_removing_letter_returns_service_without_letter(service_factory): def test_create_service_by_id_adding_and_removing_letter_returns_service_without_letter(service_factory):
service = service_factory.get('testing', email_from='testing') service = service_factory.get('testing', email_from='testing')