darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 08:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removed the performance testing statsd calls as they are no longer

Browse Source 
needed for monitoring the performance of the v2 endpoints. They were put
in as a temporary measure whilst sustained performance testing was
taking place.
This commit is contained in:
Richard Chapman
2018-01-26 09:08:45 +00:00
parent f784cc69ad
commit 083bfb9ea5
4 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notifications/process_notifications.py
View File

@@ -46,7 +46,6 @@ def check_placeholders(template_object):
raise BadRequestError(fields=[{'template': message}], message=message) raise BadRequestError(fields=[{'template': message}], message=message)
@statsd(namespace="performance-testing")
def persist_notification( def persist_notification(
*, *,
template_id, template_id,
@@ -116,7 +115,6 @@ def persist_notification(
return notification return notification
@statsd(namespace="performance-testing")
def send_notification_to_queue(notification, research_mode, queue=None): def send_notification_to_queue(notification, research_mode, queue=None):
if research_mode or notification.key_type == KEY_TYPE_TEST: if research_mode or notification.key_type == KEY_TYPE_TEST:
queue = QueueNames.RESEARCH_MODE queue = QueueNames.RESEARCH_MODE

4
app/notifications/validators.py
View File

@@ -48,7 +48,6 @@ def check_service_over_daily_message_limit(key_type, service):
raise TooManyRequestsError(service.message_limit) raise TooManyRequestsError(service.message_limit)
@statsd(namespace="performance-testing")
def check_rate_limiting(service, api_key): def check_rate_limiting(service, api_key):
check_service_over_api_rate_limit(service, api_key) check_service_over_api_rate_limit(service, api_key)
check_service_over_daily_message_limit(api_key.key_type, service) check_service_over_daily_message_limit(api_key.key_type, service)
@@ -83,14 +82,12 @@ def service_has_permission(notify_type, permissions):
return notify_type in [p.permission for p in permissions] return notify_type in [p.permission for p in permissions]
@statsd(namespace="performance-testing")
def check_service_has_permission(notify_type, permissions): def check_service_has_permission(notify_type, permissions):
if not service_has_permission(notify_type, permissions): if not service_has_permission(notify_type, permissions):
raise BadRequestError(message="Cannot send {}".format( raise BadRequestError(message="Cannot send {}".format(
get_public_notify_type_text(notify_type, plural=True))) get_public_notify_type_text(notify_type, plural=True)))
@statsd(namespace="performance-testing")
def check_service_can_schedule_notification(permissions, scheduled_for): def check_service_can_schedule_notification(permissions, scheduled_for):
if scheduled_for: if scheduled_for:
if not service_has_permission(SCHEDULE_NOTIFICATIONS, permissions): if not service_has_permission(SCHEDULE_NOTIFICATIONS, permissions):
@@ -125,7 +122,6 @@ def check_sms_content_char_count(content_count):
raise BadRequestError(message=message) raise BadRequestError(message=message)
@statsd(namespace="performance-testing")
def validate_template(template_id, personalisation, service, notification_type): def validate_template(template_id, personalisation, service, notification_type):
try: try:
template = templates_dao.dao_get_template_by_id_and_service_id( template = templates_dao.dao_get_template_by_id_and_service_id(

1
app/v2/notifications/create_response.py
View File

@@ -10,7 +10,6 @@ def create_post_sms_response_from_notification(notification, content, from_numbe
return noti return noti
@statsd(namespace="performance-testing")
def create_post_email_response_from_notification(notification, content, subject, email_from, url_root, scheduled_for): def create_post_email_response_from_notification(notification, content, subject, email_from, url_root, scheduled_for):
noti = __create_notification_response(notification, url_root, scheduled_for) noti = __create_notification_response(notification, url_root, scheduled_for)
noti['content'] = { noti['content'] = {

3
app/v2/notifications/post_notifications.py
View File

@@ -53,7 +53,6 @@ from app.v2.notifications.create_response import (
@v2_notification_blueprint.route('/<notification_type>', methods=['POST']) @v2_notification_blueprint.route('/<notification_type>', methods=['POST'])
@statsd(namespace="performance-testing")
def post_notification(notification_type): def post_notification(notification_type):
if notification_type == EMAIL_TYPE: if notification_type == EMAIL_TYPE:
form = validate(request.get_json(), post_email_request) form = validate(request.get_json(), post_email_request)
@@ -124,7 +123,6 @@ def post_notification(notification_type):
return jsonify(resp), 201 return jsonify(resp), 201
@statsd(namespace="performance-testing")
def process_sms_or_email_notification(*, form, notification_type, api_key, template, service, reply_to_text=None): def process_sms_or_email_notification(*, form, notification_type, api_key, template, service, reply_to_text=None):
form_send_to = form['email_address'] if notification_type == EMAIL_TYPE else form['phone_number'] form_send_to = form['email_address'] if notification_type == EMAIL_TYPE else form['phone_number']
@@ -199,7 +197,6 @@ def process_letter_notification(*, letter_data, api_key, template, reply_to_text
return notification return notification
@statsd(namespace="performance-testing")
def get_reply_to_text(notification_type, form, template): def get_reply_to_text(notification_type, form, template):
reply_to = None reply_to = None
if notification_type == EMAIL_TYPE: if notification_type == EMAIL_TYPE: