Merge pull request #3156 from alphagov/cronitor

make sure status is always set by finally block
This commit is contained in:
Leo Hemsted
2021-02-19 10:04:55 +00:00
committed by GitHub

View File

@@ -38,13 +38,11 @@ def cronitor(task_name):
@wraps(func) @wraps(func)
def inner_decorator(*args, **kwargs): def inner_decorator(*args, **kwargs):
ping_cronitor('run') ping_cronitor('run')
status = 'fail'
try: try:
ret = func(*args, **kwargs) ret = func(*args, **kwargs)
status = 'complete' status = 'complete'
return ret return ret
except Exception:
status = 'fail'
raise
finally: finally:
ping_cronitor(status) ping_cronitor(status)