darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-09 23:02:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Include check constraint in migration script

Browse Source 
Add check constraint that created_by_id should not be null, unless
created_by_api_key_id is not null to the migration script. It is
already in the models file.

Also remove check constraint for cancelled_by_id from models, as
this field would only be filled for broadcasts with cancelled
status.

Also add some spacing in that migration script so it is easier
to read.
This commit is contained in:
Pea Tyczynska
2022-02-02 17:21:58 +00:00
parent 82f08f230c
commit 0737eceddb
2 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
migrations/versions/0363_cancelled_by_api_key.py
View File

@@ -16,10 +16,29 @@ down_revision = '0362_broadcast_msg_event'
def upgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.add_column('broadcast_message', sa.Column('created_by_api_key_id', postgresql.UUID(as_uuid=True), nullable=True))
op.add_column('broadcast_message', sa.Column('cancelled_by_api_key_id', postgresql.UUID(as_uuid=True), nullable=True))
op.add_column(
'broadcast_message', sa.Column('cancelled_by_api_key_id', postgresql.UUID(as_uuid=True), nullable=True)
)
op.drop_constraint('broadcast_message_api_key_id_fkey', 'broadcast_message', type_='foreignkey')
op.create_foreign_key('broadcast_message_created_by_api_key_id_fkey', 'broadcast_message', 'api_keys', ['created_by_api_key_id'], ['id'])
op.create_foreign_key('broadcast_message_cancelled_by_api_key_id_fkey', 'broadcast_message', 'api_keys', ['cancelled_by_api_key_id'], ['id'])
op.create_foreign_key(
'broadcast_message_created_by_api_key_id_fkey',
'broadcast_message',
'api_keys',
['created_by_api_key_id'],
['id']
)
op.create_foreign_key(
'broadcast_message_cancelled_by_api_key_id_fkey',
'broadcast_message',
'api_keys',
['cancelled_by_api_key_id'],
['id']
)
op.create_check_constraint(
"ck_broadcast_message_created_by_not_null",
"broadcast_message",
"created_by_id is not null or created_by_api_key_id is not null"
)
op.get_bind()
op.execute("UPDATE broadcast_message SET created_by_api_key_id=api_key_id") # move data over
op.drop_column('broadcast_message', 'api_key_id')
@@ -29,6 +48,10 @@ def upgrade():
def downgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.add_column('broadcast_message', sa.Column('api_key_id', postgresql.UUID(), autoincrement=False, nullable=True))
op.drop_constraint(
"ck_broadcast_message_created_by_not_null",
"broadcast_message"
)
op.drop_constraint('broadcast_message_created_by_api_key_id_fkey', 'broadcast_message', type_='foreignkey')
op.drop_constraint('broadcast_message_cancelled_by_api_key_id_fkey', 'broadcast_message', type_='foreignkey')
op.create_foreign_key('broadcast_message_api_key_id_fkey', 'broadcast_message', 'api_keys', ['api_key_id'], ['id'])