Remove unused metric for SQS apply duration

This was added as part of a wider performance investigation [1]. I
checked with Leo, who made the change, and while the other metrics
are still be useful, there's no reason to keep this one.

[1]: https://github.com/alphagov/notifications-api/commit/6e32ca59963b53a8a404b9362a56fc689d6fd4c2#diff-76936416943346b5f691dac57a64acebc6a1227293820d1d9af4791087c9fb9eR23
This commit is contained in:
Ben Thorner
2021-04-08 13:00:21 +01:00
parent df97b28c57
commit 054205835b
+1 -9
View File
@@ -4,7 +4,6 @@ from celery import Celery, Task
from celery.signals import worker_process_shutdown
from flask import g, request
from flask.ctx import has_app_context, has_request_context
from gds_metrics.metrics import Histogram
@worker_process_shutdown.connect
@@ -20,12 +19,6 @@ def log_on_worker_shutdown(sender, signal, pid, exitcode, **kwargs):
def make_task(app):
SQS_APPLY_ASYNC_DURATION_SECONDS = Histogram(
'sqs_apply_async_duration_seconds',
'Time taken to put task on queue',
['task_name']
)
class NotifyTask(Task):
abstract = True
start = None
@@ -60,8 +53,7 @@ def make_task(app):
elif has_app_context() and 'request_id' in g:
kwargs['request_id'] = g.request_id
with SQS_APPLY_ASYNC_DURATION_SECONDS.labels(self.name).time():
return super().apply_async(args, kwargs, task_id, producer, link, link_error, **options)
return super().apply_async(args, kwargs, task_id, producer, link, link_error, **options)
return NotifyTask