From 0515c5147557d0a66a4ed11b61b2148410c31957 Mon Sep 17 00:00:00 2001 From: Leo Hemsted Date: Thu, 16 Feb 2017 17:44:04 +0000 Subject: [PATCH] replace notify_api with client fixture in user/test_rest.py --- tests/app/user/test_rest.py | 600 +++++++++++++---------------- tests/app/user/test_rest_verify.py | 2 +- 2 files changed, 272 insertions(+), 330 deletions(-) diff --git a/tests/app/user/test_rest.py b/tests/app/user/test_rest.py index e66ab816f..a1070fcff 100644 --- a/tests/app/user/test_rest.py +++ b/tests/app/user/test_rest.py @@ -10,177 +10,165 @@ from app.dao.permissions_dao import default_service_permissions from tests import create_authorization_header -def test_get_user_list(notify_api, notify_db, notify_db_session, sample_service): +def test_get_user_list(client, sample_service): """ Tests GET endpoint '/' to retrieve entire user list. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - header = create_authorization_header() - response = client.get(url_for('user.get_user'), - headers=[header]) - assert response.status_code == 200 - json_resp = json.loads(response.get_data(as_text=True)) - assert len(json_resp['data']) == 1 - sample_user = sample_service.users[0] - expected_permissions = default_service_permissions - fetched = json_resp['data'][0] + header = create_authorization_header() + response = client.get(url_for('user.get_user'), + headers=[header]) + assert response.status_code == 200 + json_resp = json.loads(response.get_data(as_text=True)) + assert len(json_resp['data']) == 1 + sample_user = sample_service.users[0] + expected_permissions = default_service_permissions + fetched = json_resp['data'][0] - assert str(sample_user.id) == fetched['id'] - assert sample_user.name == fetched['name'] - assert sample_user.mobile_number == fetched['mobile_number'] - assert sample_user.email_address == fetched['email_address'] - assert sample_user.state == fetched['state'] - assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) + assert str(sample_user.id) == fetched['id'] + assert sample_user.name == fetched['name'] + assert sample_user.mobile_number == fetched['mobile_number'] + assert sample_user.email_address == fetched['email_address'] + assert sample_user.state == fetched['state'] + assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) -def test_get_user(notify_api, notify_db, notify_db_session, sample_service): +def test_get_user(client, sample_service): """ Tests GET endpoint '/' to retrieve a single service. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - sample_user = sample_service.users[0] - header = create_authorization_header() - resp = client.get(url_for('user.get_user', - user_id=sample_user.id), - headers=[header]) - assert resp.status_code == 200 - json_resp = json.loads(resp.get_data(as_text=True)) + sample_user = sample_service.users[0] + header = create_authorization_header() + resp = client.get(url_for('user.get_user', + user_id=sample_user.id), + headers=[header]) + assert resp.status_code == 200 + json_resp = json.loads(resp.get_data(as_text=True)) - expected_permissions = default_service_permissions - fetched = json_resp['data'] + expected_permissions = default_service_permissions + fetched = json_resp['data'] - assert str(sample_user.id) == fetched['id'] - assert sample_user.name == fetched['name'] - assert sample_user.mobile_number == fetched['mobile_number'] - assert sample_user.email_address == fetched['email_address'] - assert sample_user.state == fetched['state'] - assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) + assert str(sample_user.id) == fetched['id'] + assert sample_user.name == fetched['name'] + assert sample_user.mobile_number == fetched['mobile_number'] + assert sample_user.email_address == fetched['email_address'] + assert sample_user.state == fetched['state'] + assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) -def test_post_user(notify_api, notify_db, notify_db_session): +def test_post_user(client, notify_db, notify_db_session): """ Tests POST endpoint '/' to create a user. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - assert User.query.count() == 0 - data = { - "name": "Test User", - "email_address": "user@digital.cabinet-office.gov.uk", - "password": "password", - "mobile_number": "+447700900986", - "logged_in_at": None, - "state": "active", - "failed_login_count": 0, - "permissions": {} - } - auth_header = create_authorization_header() - headers = [('Content-Type', 'application/json'), auth_header] - resp = client.post( - url_for('user.create_user'), - data=json.dumps(data), - headers=headers) - assert resp.status_code == 201 - user = User.query.filter_by(email_address='user@digital.cabinet-office.gov.uk').first() - json_resp = json.loads(resp.get_data(as_text=True)) - assert json_resp['data']['email_address'] == user.email_address - assert json_resp['data']['id'] == str(user.id) + assert User.query.count() == 0 + data = { + "name": "Test User", + "email_address": "user@digital.cabinet-office.gov.uk", + "password": "password", + "mobile_number": "+447700900986", + "logged_in_at": None, + "state": "active", + "failed_login_count": 0, + "permissions": {} + } + auth_header = create_authorization_header() + headers = [('Content-Type', 'application/json'), auth_header] + resp = client.post( + url_for('user.create_user'), + data=json.dumps(data), + headers=headers) + assert resp.status_code == 201 + user = User.query.filter_by(email_address='user@digital.cabinet-office.gov.uk').first() + json_resp = json.loads(resp.get_data(as_text=True)) + assert json_resp['data']['email_address'] == user.email_address + assert json_resp['data']['id'] == str(user.id) -def test_post_user_missing_attribute_email(notify_api, notify_db, notify_db_session): +def test_post_user_missing_attribute_email(client, notify_db, notify_db_session): """ Tests POST endpoint '/' missing attribute email. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - assert User.query.count() == 0 - data = { - "name": "Test User", - "password": "password", - "mobile_number": "+447700900986", - "logged_in_at": None, - "state": "active", - "failed_login_count": 0, - "permissions": {} - } - auth_header = create_authorization_header() - headers = [('Content-Type', 'application/json'), auth_header] - resp = client.post( - url_for('user.create_user'), - data=json.dumps(data), - headers=headers) - assert resp.status_code == 400 - assert User.query.count() == 0 - json_resp = json.loads(resp.get_data(as_text=True)) - assert {'email_address': ['Missing data for required field.']} == json_resp['message'] + assert User.query.count() == 0 + data = { + "name": "Test User", + "password": "password", + "mobile_number": "+447700900986", + "logged_in_at": None, + "state": "active", + "failed_login_count": 0, + "permissions": {} + } + auth_header = create_authorization_header() + headers = [('Content-Type', 'application/json'), auth_header] + resp = client.post( + url_for('user.create_user'), + data=json.dumps(data), + headers=headers) + assert resp.status_code == 400 + assert User.query.count() == 0 + json_resp = json.loads(resp.get_data(as_text=True)) + assert {'email_address': ['Missing data for required field.']} == json_resp['message'] -def test_create_user_missing_attribute_password(notify_api, notify_db, notify_db_session): +def test_create_user_missing_attribute_password(client, notify_db, notify_db_session): """ Tests POST endpoint '/' missing attribute password. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - assert User.query.count() == 0 - data = { - "name": "Test User", - "email_address": "user@digital.cabinet-office.gov.uk", - "mobile_number": "+447700900986", - "logged_in_at": None, - "state": "active", - "failed_login_count": 0, - "permissions": {} - } - auth_header = create_authorization_header() - headers = [('Content-Type', 'application/json'), auth_header] - resp = client.post( - url_for('user.create_user'), - data=json.dumps(data), - headers=headers) - assert resp.status_code == 400 - assert User.query.count() == 0 - json_resp = json.loads(resp.get_data(as_text=True)) - assert {'password': ['Missing data for required field.']} == json_resp['message'] + assert User.query.count() == 0 + data = { + "name": "Test User", + "email_address": "user@digital.cabinet-office.gov.uk", + "mobile_number": "+447700900986", + "logged_in_at": None, + "state": "active", + "failed_login_count": 0, + "permissions": {} + } + auth_header = create_authorization_header() + headers = [('Content-Type', 'application/json'), auth_header] + resp = client.post( + url_for('user.create_user'), + data=json.dumps(data), + headers=headers) + assert resp.status_code == 400 + assert User.query.count() == 0 + json_resp = json.loads(resp.get_data(as_text=True)) + assert {'password': ['Missing data for required field.']} == json_resp['message'] -def test_put_user(notify_api, notify_db, notify_db_session, sample_service): +def test_put_user(client, sample_service): """ Tests PUT endpoint '/' to update a user. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - assert User.query.count() == 1 - sample_user = sample_service.users[0] - sample_user.failed_login_count = 1 - new_email = 'new@digital.cabinet-office.gov.uk' - data = { - 'name': sample_user.name, - 'email_address': new_email, - 'mobile_number': sample_user.mobile_number - } - auth_header = create_authorization_header() - headers = [('Content-Type', 'application/json'), auth_header] - resp = client.put( - url_for('user.update_user', user_id=sample_user.id), - data=json.dumps(data), - headers=headers) - assert resp.status_code == 200 - assert User.query.count() == 1 - json_resp = json.loads(resp.get_data(as_text=True)) - assert json_resp['data']['email_address'] == new_email - expected_permissions = default_service_permissions - fetched = json_resp['data'] + assert User.query.count() == 1 + sample_user = sample_service.users[0] + sample_user.failed_login_count = 1 + new_email = 'new@digital.cabinet-office.gov.uk' + data = { + 'name': sample_user.name, + 'email_address': new_email, + 'mobile_number': sample_user.mobile_number + } + auth_header = create_authorization_header() + headers = [('Content-Type', 'application/json'), auth_header] + resp = client.put( + url_for('user.update_user', user_id=sample_user.id), + data=json.dumps(data), + headers=headers) + assert resp.status_code == 200 + assert User.query.count() == 1 + json_resp = json.loads(resp.get_data(as_text=True)) + assert json_resp['data']['email_address'] == new_email + expected_permissions = default_service_permissions + fetched = json_resp['data'] - assert str(sample_user.id) == fetched['id'] - assert sample_user.name == fetched['name'] - assert sample_user.mobile_number == fetched['mobile_number'] - assert new_email == fetched['email_address'] - assert sample_user.state == fetched['state'] - assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) - # password wasn't updated, so failed_login_count stays the same - assert sample_user.failed_login_count == 1 + assert str(sample_user.id) == fetched['id'] + assert sample_user.name == fetched['name'] + assert sample_user.mobile_number == fetched['mobile_number'] + assert new_email == fetched['email_address'] + assert sample_user.state == fetched['state'] + assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) + # password wasn't updated, so failed_login_count stays the same + assert sample_user.failed_login_count == 1 @pytest.mark.parametrize('user_attribute, user_value', [ @@ -206,214 +194,169 @@ def test_post_user_attribute(client, sample_user, user_attribute, user_value): assert json_resp['data'][user_attribute] == user_value -def test_put_user_update_password(notify_api, - notify_db, - notify_db_session, - sample_service): +def test_put_user_update_password(client, sample_service): """ Tests PUT endpoint '/' to update a user including their password. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - assert User.query.count() == 1 - sample_user = sample_service.users[0] - new_password = '1234567890' - data = { - 'name': sample_user.name, - 'email_address': sample_user.email_address, - 'mobile_number': sample_user.mobile_number, - 'password': new_password - } - auth_header = create_authorization_header() - headers = [('Content-Type', 'application/json'), auth_header] - resp = client.put( - url_for('user.update_user', user_id=sample_user.id), - data=json.dumps(data), - headers=headers) - assert resp.status_code == 200 - assert User.query.count() == 1 - json_resp = json.loads(resp.get_data(as_text=True)) - assert json_resp['data']['password_changed_at'] is not None - data = {'password': new_password} - auth_header = create_authorization_header() - headers = [('Content-Type', 'application/json'), auth_header] - resp = client.post( - url_for('user.verify_user_password', user_id=str(sample_user.id)), - data=json.dumps(data), - headers=headers) - assert resp.status_code == 204 + assert User.query.count() == 1 + sample_user = sample_service.users[0] + new_password = '1234567890' + data = { + 'name': sample_user.name, + 'email_address': sample_user.email_address, + 'mobile_number': sample_user.mobile_number, + 'password': new_password + } + auth_header = create_authorization_header() + headers = [('Content-Type', 'application/json'), auth_header] + resp = client.put( + url_for('user.update_user', user_id=sample_user.id), + data=json.dumps(data), + headers=headers) + assert resp.status_code == 200 + assert User.query.count() == 1 + json_resp = json.loads(resp.get_data(as_text=True)) + assert json_resp['data']['password_changed_at'] is not None + data = {'password': new_password} + auth_header = create_authorization_header() + headers = [('Content-Type', 'application/json'), auth_header] + resp = client.post( + url_for('user.verify_user_password', user_id=str(sample_user.id)), + data=json.dumps(data), + headers=headers) + assert resp.status_code == 204 -def test_put_user_not_exists(notify_api, notify_db, notify_db_session, sample_user, fake_uuid): +def test_put_user_not_exists(client, sample_user, fake_uuid): """ Tests PUT endpoint '/' to update a user doesn't exist. """ - with notify_api.test_request_context(): - with notify_api.test_client() as client: - assert User.query.count() == 1 - new_email = 'new@digital.cabinet-office.gov.uk' - data = {'email_address': new_email} - auth_header = create_authorization_header() - headers = [('Content-Type', 'application/json'), auth_header] - resp = client.put( - url_for('user.update_user', user_id=fake_uuid), - data=json.dumps(data), - headers=headers) - assert resp.status_code == 404 - assert User.query.count() == 1 - user = User.query.filter_by(id=str(sample_user.id)).first() - json_resp = json.loads(resp.get_data(as_text=True)) - assert json_resp['result'] == "error" - assert json_resp['message'] == 'No result found' + assert User.query.count() == 1 + new_email = 'new@digital.cabinet-office.gov.uk' + data = {'email_address': new_email} + auth_header = create_authorization_header() + headers = [('Content-Type', 'application/json'), auth_header] + resp = client.put( + url_for('user.update_user', user_id=fake_uuid), + data=json.dumps(data), + headers=headers) + assert resp.status_code == 404 + assert User.query.count() == 1 + user = User.query.filter_by(id=str(sample_user.id)).first() + json_resp = json.loads(resp.get_data(as_text=True)) + assert json_resp['result'] == "error" + assert json_resp['message'] == 'No result found' - assert user == sample_user - assert user.email_address != new_email + assert user == sample_user + assert user.email_address != new_email -def test_get_user_by_email(notify_api, notify_db, notify_db_session, sample_service): +def test_get_user_by_email(client, sample_service): + sample_user = sample_service.users[0] + header = create_authorization_header() + url = url_for('user.get_by_email', email=sample_user.email_address) + resp = client.get(url, headers=[header]) + assert resp.status_code == 200 - with notify_api.test_request_context(): - with notify_api.test_client() as client: - sample_user = sample_service.users[0] - header = create_authorization_header() - url = url_for('user.get_by_email', email=sample_user.email_address) - resp = client.get(url, headers=[header]) - assert resp.status_code == 200 + json_resp = json.loads(resp.get_data(as_text=True)) + expected_permissions = default_service_permissions + fetched = json_resp['data'] - json_resp = json.loads(resp.get_data(as_text=True)) - expected_permissions = default_service_permissions - fetched = json_resp['data'] - - assert str(sample_user.id) == fetched['id'] - assert sample_user.name == fetched['name'] - assert sample_user.mobile_number == fetched['mobile_number'] - assert sample_user.email_address == fetched['email_address'] - assert sample_user.state == fetched['state'] - assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) + assert str(sample_user.id) == fetched['id'] + assert sample_user.name == fetched['name'] + assert sample_user.mobile_number == fetched['mobile_number'] + assert sample_user.email_address == fetched['email_address'] + assert sample_user.state == fetched['state'] + assert sorted(expected_permissions) == sorted(fetched['permissions'][str(sample_service.id)]) -def test_get_user_by_email_not_found_returns_404(notify_api, - notify_db, - notify_db_session, - sample_user): - - with notify_api.test_request_context(): - with notify_api.test_client() as client: - header = create_authorization_header() - url = url_for('user.get_by_email', email='no_user@digital.gov.uk') - resp = client.get(url, headers=[header]) - assert resp.status_code == 404 - json_resp = json.loads(resp.get_data(as_text=True)) - assert json_resp['result'] == 'error' - assert json_resp['message'] == 'No result found' +def test_get_user_by_email_not_found_returns_404(client, sample_user): + header = create_authorization_header() + url = url_for('user.get_by_email', email='no_user@digital.gov.uk') + resp = client.get(url, headers=[header]) + assert resp.status_code == 404 + json_resp = json.loads(resp.get_data(as_text=True)) + assert json_resp['result'] == 'error' + assert json_resp['message'] == 'No result found' -def test_get_user_by_email_bad_url_returns_404(notify_api, - notify_db, - notify_db_session, - sample_user): - - with notify_api.test_request_context(): - with notify_api.test_client() as client: - header = create_authorization_header() - url = '/user/email' - resp = client.get(url, headers=[header]) - assert resp.status_code == 400 - json_resp = json.loads(resp.get_data(as_text=True)) - assert json_resp['result'] == 'error' - assert json_resp['message'] == 'Invalid request. Email query string param required' +def test_get_user_by_email_bad_url_returns_404(client, sample_user): + header = create_authorization_header() + url = '/user/email' + resp = client.get(url, headers=[header]) + assert resp.status_code == 400 + json_resp = json.loads(resp.get_data(as_text=True)) + assert json_resp['result'] == 'error' + assert json_resp['message'] == 'Invalid request. Email query string param required' -def test_get_user_with_permissions(notify_api, - notify_db, - notify_db_session, - sample_service_permission): - with notify_api.test_request_context(): - with notify_api.test_client() as client: - header = create_authorization_header() - response = client.get(url_for('user.get_user', user_id=str(sample_service_permission.user.id)), - headers=[header]) - assert response.status_code == 200 - permissions = json.loads(response.get_data(as_text=True))['data']['permissions'] - assert sample_service_permission.permission in permissions[str(sample_service_permission.service.id)] +def test_get_user_with_permissions(client, sample_service_permission): + header = create_authorization_header() + response = client.get(url_for('user.get_user', user_id=str(sample_service_permission.user.id)), + headers=[header]) + assert response.status_code == 200 + permissions = json.loads(response.get_data(as_text=True))['data']['permissions'] + assert sample_service_permission.permission in permissions[str(sample_service_permission.service.id)] -def test_set_user_permissions(notify_api, - notify_db, - notify_db_session, - sample_user, - sample_service): - with notify_api.test_request_context(): - with notify_api.test_client() as client: - data = json.dumps([{'permission': MANAGE_SETTINGS}]) - header = create_authorization_header() - headers = [('Content-Type', 'application/json'), header] - response = client.post( - url_for( - 'user.set_permissions', - user_id=str(sample_user.id), - service_id=str(sample_service.id)), - headers=headers, - data=data) +def test_set_user_permissions(client, sample_user, sample_service): + data = json.dumps([{'permission': MANAGE_SETTINGS}]) + header = create_authorization_header() + headers = [('Content-Type', 'application/json'), header] + response = client.post( + url_for( + 'user.set_permissions', + user_id=str(sample_user.id), + service_id=str(sample_service.id)), + headers=headers, + data=data) - assert response.status_code == 204 - permission = Permission.query.filter_by(permission=MANAGE_SETTINGS).first() - assert permission.user == sample_user - assert permission.service == sample_service - assert permission.permission == MANAGE_SETTINGS + assert response.status_code == 204 + permission = Permission.query.filter_by(permission=MANAGE_SETTINGS).first() + assert permission.user == sample_user + assert permission.service == sample_service + assert permission.permission == MANAGE_SETTINGS -def test_set_user_permissions_multiple(notify_api, - notify_db, - notify_db_session, - sample_user, - sample_service): - with notify_api.test_request_context(): - with notify_api.test_client() as client: - data = json.dumps([{'permission': MANAGE_SETTINGS}, {'permission': MANAGE_TEMPLATES}]) - header = create_authorization_header() - headers = [('Content-Type', 'application/json'), header] - response = client.post( - url_for( - 'user.set_permissions', - user_id=str(sample_user.id), - service_id=str(sample_service.id)), - headers=headers, - data=data) +def test_set_user_permissions_multiple(client, sample_user, sample_service): + data = json.dumps([{'permission': MANAGE_SETTINGS}, {'permission': MANAGE_TEMPLATES}]) + header = create_authorization_header() + headers = [('Content-Type', 'application/json'), header] + response = client.post( + url_for( + 'user.set_permissions', + user_id=str(sample_user.id), + service_id=str(sample_service.id)), + headers=headers, + data=data) - assert response.status_code == 204 - permission = Permission.query.filter_by(permission=MANAGE_SETTINGS).first() - assert permission.user == sample_user - assert permission.service == sample_service - assert permission.permission == MANAGE_SETTINGS - permission = Permission.query.filter_by(permission=MANAGE_TEMPLATES).first() - assert permission.user == sample_user - assert permission.service == sample_service - assert permission.permission == MANAGE_TEMPLATES + assert response.status_code == 204 + permission = Permission.query.filter_by(permission=MANAGE_SETTINGS).first() + assert permission.user == sample_user + assert permission.service == sample_service + assert permission.permission == MANAGE_SETTINGS + permission = Permission.query.filter_by(permission=MANAGE_TEMPLATES).first() + assert permission.user == sample_user + assert permission.service == sample_service + assert permission.permission == MANAGE_TEMPLATES -def test_set_user_permissions_remove_old(notify_api, - notify_db, - notify_db_session, - sample_user, - sample_service): - with notify_api.test_request_context(): - with notify_api.test_client() as client: - data = json.dumps([{'permission': MANAGE_SETTINGS}]) - header = create_authorization_header() - headers = [('Content-Type', 'application/json'), header] - response = client.post( - url_for( - 'user.set_permissions', - user_id=str(sample_user.id), - service_id=str(sample_service.id)), - headers=headers, - data=data) +def test_set_user_permissions_remove_old(client, sample_user, sample_service): + data = json.dumps([{'permission': MANAGE_SETTINGS}]) + header = create_authorization_header() + headers = [('Content-Type', 'application/json'), header] + response = client.post( + url_for( + 'user.set_permissions', + user_id=str(sample_user.id), + service_id=str(sample_service.id)), + headers=headers, + data=data) - assert response.status_code == 204 - query = Permission.query.filter_by(user=sample_user) - assert query.count() == 1 - assert query.first().permission == MANAGE_SETTINGS + assert response.status_code == 204 + query = Permission.query.filter_by(user=sample_user) + assert query.count() == 1 + assert query.first().permission == MANAGE_SETTINGS @freeze_time("2016-01-01 11:09:00.061258") @@ -449,8 +392,7 @@ def test_send_user_reset_password_should_return_400_when_email_is_missing(client assert mocked.call_count == 0 -def test_send_user_reset_password_should_return_400_when_user_doesnot_exist(client, - mocker): +def test_send_user_reset_password_should_return_400_when_user_doesnot_exist(client, mocker): mocked = mocker.patch('app.celery.provider_tasks.deliver_email.apply_async') bad_email_address = 'bad@email.gov.uk' data = json.dumps({'email': bad_email_address}) @@ -498,15 +440,15 @@ def test_send_already_registered_email(client, sample_user, already_registered_t def test_send_already_registered_email_returns_400_when_data_is_missing(client, sample_user): - data = json.dumps({}) - auth_header = create_authorization_header() + data = json.dumps({}) + auth_header = create_authorization_header() - resp = client.post( - url_for('user.send_already_registered_email', user_id=str(sample_user.id)), - data=data, - headers=[('Content-Type', 'application/json'), auth_header]) - assert resp.status_code == 400 - assert json.loads(resp.get_data(as_text=True))['message'] == {'email': ['Missing data for required field.']} + resp = client.post( + url_for('user.send_already_registered_email', user_id=str(sample_user.id)), + data=data, + headers=[('Content-Type', 'application/json'), auth_header]) + assert resp.status_code == 400 + assert json.loads(resp.get_data(as_text=True))['message'] == {'email': ['Missing data for required field.']} def test_send_user_confirm_new_email_returns_204(client, sample_user, change_email_confirmation_template, mocker): diff --git a/tests/app/user/test_rest_verify.py b/tests/app/user/test_rest_verify.py index 63d4b61d3..043321d03 100644 --- a/tests/app/user/test_rest_verify.py +++ b/tests/app/user/test_rest_verify.py @@ -291,7 +291,7 @@ def test_send_email_verification_returns_404_for_bad_input_data(client, notify_d def test_user_verify_user_code_valid_code_resets_failed_login_count(client, sample_sms_code): - sample_sms_code.failed_login_count = 1 + sample_sms_code.user.failed_login_count = 1 data = json.dumps({ 'code_type': sample_sms_code.code_type, 'code': sample_sms_code.txt_code})