darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Return sorted ACK files

Browse Source 
- also fixes unit test failure due to random order of filenames
This commit is contained in:
Ken Tsang
2018-01-24 15:57:24 +00:00
parent edd030e5dd
commit 04beff7d05
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/scheduled_tasks.py
View File

@@ -526,7 +526,7 @@ def letter_raise_alert_if_no_ack_file_for_zip():
deskpro_message = "Letter ack file does not contains all zip files sent. " \ deskpro_message = "Letter ack file does not contains all zip files sent. " \
"Missing ack for zip files: {}, " \ "Missing ack for zip files: {}, " \
"pdf bucket: {}, subfolder: {}, " \ "pdf bucket: {}, subfolder: {}, " \
"ack bucket: {}".format(str(zip_file_set - ack_content_set), "ack bucket: {}".format(str(sorted(zip_file_set - ack_content_set)),
current_app.config['LETTERS_PDF_BUCKET_NAME'], current_app.config['LETTERS_PDF_BUCKET_NAME'],
datetime.utcnow().strftime('%Y-%m-%d') + '/zips_sent', datetime.utcnow().strftime('%Y-%m-%d') + '/zips_sent',
current_app.config['DVLA_RESPONSE_BUCKET_NAME']) current_app.config['DVLA_RESPONSE_BUCKET_NAME'])

2
tests/app/celery/test_scheduled_tasks.py
View File

@@ -1159,7 +1159,7 @@ def test_letter_raise_alert_if_ack_files_not_match_zip_list(mocker, notify_db):
deskpro_message = "Letter ack file does not contains all zip files sent. " \ deskpro_message = "Letter ack file does not contains all zip files sent. " \
"Missing ack for zip files: {}, " \ "Missing ack for zip files: {}, " \
"pdf bucket: {}, subfolder: {}, " \ "pdf bucket: {}, subfolder: {}, " \
"ack bucket: {}".format(str(set(['NOTIFY.20180111175009.ZIP', 'NOTIFY.20180111175010.ZIP'])), "ack bucket: {}".format(str(['NOTIFY.20180111175009.ZIP', 'NOTIFY.20180111175010.ZIP']),
current_app.config['LETTERS_PDF_BUCKET_NAME'], current_app.config['LETTERS_PDF_BUCKET_NAME'],
datetime.utcnow().strftime('%Y-%m-%d') + '/zips_sent', datetime.utcnow().strftime('%Y-%m-%d') + '/zips_sent',
current_app.config['DVLA_RESPONSE_BUCKET_NAME']) current_app.config['DVLA_RESPONSE_BUCKET_NAME'])