Update the dao_get_notification_outcomes_for_job to return the stats from either the notification table or the ft_notification_status table.

Currently if you visit the job page and the job is older than the data retention the totals on the page are all wrong because this query gets the counts from the notification table. With this change the data should always be correct. It also eliminates the need for looking at data retention. If the job is new and nothing has been created yet (i.e. the job hasn't started yet) then the page should show the correctly because the outcomes are empty (as expected), once the notifications for the jobs are created the numbers will start going up.

app/dao/jobs_dao.py

@@ -27,15 +27,15 @@ from app.models import (
     ServiceDataRetention,
     NOTIFICATION_CREATED,
     NOTIFICATION_CANCELLED,
-    JOB_STATUS_CANCELLED
+    JOB_STATUS_CANCELLED,
+    FactNotificationStatus
 )
 
 
 @statsd(namespace="dao")
 def dao_get_notification_outcomes_for_job(service_id, job_id):
-    return db.session.query(
-        func.count(Notification.status).label('count'),
-        Notification.status
+    notification_statuses = db.session.query(
+        func.count(Notification.status).label('count'), Notification.status
     ).filter(
         Notification.service_id == service_id,
         Notification.job_id == job_id
@@ -43,6 +43,16 @@ def dao_get_notification_outcomes_for_job(service_id, job_id):
         Notification.status
     ).all()
 
+    if not notification_statuses:
+        notification_statuses = db.session.query(
+            FactNotificationStatus.notification_count.label('count'),
+            FactNotificationStatus.notification_status.label('status')
+        ).filter(
+            FactNotificationStatus.service_id == service_id,
+            FactNotificationStatus.job_id == job_id
+        ).all()
+    return notification_statuses
+
 
 def dao_get_job_by_service_id_and_job_id(service_id, job_id):
     return Job.query.filter_by(service_id=service_id, id=job_id).one()