Split generating authorization headers by type

In response to [1].

[1]: https://github.com/alphagov/notifications-api/pull/3300#discussion_r681653248
This commit is contained in:
Ben Thorner
2021-08-04 15:12:09 +01:00
parent 5a1636e41f
commit 0312e2a528
33 changed files with 526 additions and 512 deletions

View File

@@ -6,7 +6,7 @@ from flask import json
from app.dao.broadcast_message_dao import (
dao_get_broadcast_message_by_id_and_service_id,
)
from tests import create_authorization_header
from tests import create_service_authorization_header
from . import sample_cap_xml_documents
@@ -15,7 +15,7 @@ def test_broadcast_for_service_without_permission_returns_400(
client,
sample_service,
):
auth_header = create_authorization_header(service_id=sample_service.id)
auth_header = create_service_authorization_header(service_id=sample_service.id)
response = client.post(
path='/v2/broadcast',
data='',
@@ -32,7 +32,7 @@ def test_valid_post_broadcast_returns_201(
client,
sample_broadcast_service,
):
auth_header = create_authorization_header(service_id=sample_broadcast_service.id)
auth_header = create_service_authorization_header(service_id=sample_broadcast_service.id)
response = client.post(
path='/v2/broadcast',
@@ -71,7 +71,7 @@ def test_valid_post_cap_xml_broadcast_returns_201(
client,
sample_broadcast_service,
):
auth_header = create_authorization_header(service_id=sample_broadcast_service.id)
auth_header = create_service_authorization_header(service_id=sample_broadcast_service.id)
response = client.post(
path='/v2/broadcast',
@@ -121,7 +121,7 @@ def test_valid_post_cap_xml_broadcast_sets_stubbed_to_true_for_training_mode_ser
training_mode_service
):
sample_broadcast_service.restricted = training_mode_service
auth_header = create_authorization_header(service_id=sample_broadcast_service.id)
auth_header = create_service_authorization_header(service_id=sample_broadcast_service.id)
response = client.post(
path='/v2/broadcast',
@@ -147,7 +147,7 @@ def test_invalid_post_cap_xml_broadcast_returns_400(
sample_broadcast_service,
xml_document,
):
auth_header = create_authorization_header(service_id=sample_broadcast_service.id)
auth_header = create_service_authorization_header(service_id=sample_broadcast_service.id)
response = client.post(
path='/v2/broadcast',
@@ -179,7 +179,7 @@ def test_unsupported_message_types_400(
xml_document,
expected_error_message,
):
auth_header = create_authorization_header(service_id=sample_broadcast_service.id)
auth_header = create_service_authorization_header(service_id=sample_broadcast_service.id)
response = client.post(
path='/v2/broadcast',
@@ -211,7 +211,7 @@ def test_content_too_long_returns_400(
xml_document,
expected_error,
):
auth_header = create_authorization_header(service_id=sample_broadcast_service.id)
auth_header = create_service_authorization_header(service_id=sample_broadcast_service.id)
response = client.post(
path='/v2/broadcast',
data=xml_document,