darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Split generating authorization headers by type

Browse Source 
In response to [1].

[1]: https://github.com/alphagov/notifications-api/pull/3300#discussion_r681653248
This commit is contained in:
Ben Thorner
2021-08-04 15:12:09 +01:00
parent 5a1636e41f
commit 0312e2a528
33 changed files with 526 additions and 512 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/app/complaint/test_complaint_rest.py
View File

@@ -4,7 +4,7 @@ from datetime import date
from flask import url_for
from freezegun import freeze_time
from tests import create_authorization_header
from tests import create_admin_authorization_header
from tests.app.db import (
create_complaint,
create_notification,
@@ -20,7 +20,7 @@ def test_get_all_complaints_returns_complaints_for_multiple_services(client, not
complaint_1 = create_complaint() # default service
complaint_2 = create_complaint(service=service, notification=notification)
response = client.get('/complaint', headers=[create_authorization_header()])
response = client.get('/complaint', headers=[create_admin_authorization_header()])
assert response.status_code == 200
assert json.loads(response.get_data(as_text=True))['complaints'] == [
@@ -28,7 +28,7 @@ def test_get_all_complaints_returns_complaints_for_multiple_services(client, not
def test_get_all_complaints_returns_empty_complaints_list(client):
response = client.get('/complaint', headers=[create_authorization_header()])
response = client.get('/complaint', headers=[create_admin_authorization_header()])
assert response.status_code == 200
assert json.loads(response.get_data(as_text=True))['complaints'] == []
@@ -43,7 +43,10 @@ def test_get_all_complaints_returns_pagination_links(mocker, client, notify_db_s
create_complaint(service=service_1)
create_complaint(service=service_2)
response = client.get(url_for('complaint.get_all_complaints', page=2), headers=[create_authorization_header()])
response = client.get(
url_for('complaint.get_all_complaints', page=2),
headers=[create_admin_authorization_header()]
)
assert response.status_code == 200
assert json.loads(response.get_data(as_text=True))['links'] == {
@@ -58,7 +61,7 @@ def test_get_complaint_with_start_and_end_date_passes_these_to_dao_function(mock
dao_mock = mocker.patch('app.complaint.complaint_rest.fetch_count_of_complaints', return_value=3)
response = client.get(
url_for('complaint.get_complaint_count', start_date=start_date, end_date=end_date),
headers=[create_authorization_header()]
headers=[create_admin_authorization_header()]
)
dao_mock.assert_called_once_with(start_date=start_date, end_date=end_date)
@@ -69,7 +72,7 @@ def test_get_complaint_with_start_and_end_date_passes_these_to_dao_function(mock
@freeze_time("2018-06-01 11:00:00")
def test_get_complaint_sets_start_and_end_date_to_today_if_not_specified(mocker, client):
dao_mock = mocker.patch('app.complaint.complaint_rest.fetch_count_of_complaints', return_value=5)
response = client.get(url_for('complaint.get_complaint_count'), headers=[create_authorization_header()])
response = client.get(url_for('complaint.get_complaint_count'), headers=[create_admin_authorization_header()])
dao_mock.assert_called_once_with(start_date=date.today(), end_date=date.today())
assert response.status_code == 200
@@ -80,7 +83,7 @@ def test_get_complaint_with_invalid_data_returns_400_status_code(client):
start_date = '1234-56-78'
response = client.get(
url_for('complaint.get_complaint_count', start_date=start_date),
headers=[create_authorization_header()]
headers=[create_admin_authorization_header()]
)
assert response.status_code == 400