darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-20 14:29:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #72 from alphagov/fix-template-validation

Browse Source 
Fix validation of template for service.
This commit is contained in:
NIcholas Staples
2016-02-15 15:10:16 +00:00
parent e7ef5945e5 fcaed04918
commit 025a6fb47e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/schemas.py
View File

@@ -122,7 +122,9 @@ class SmsTemplateNotificationSchema(SmsNotificationSchema):
raise ValidationError('Invalid phone number for restricted service', 'restricted') raise ValidationError('Invalid phone number for restricted service', 'restricted')
# Assert the template is valid for the service which made the request. # Assert the template is valid for the service which made the request.
service = api_user['client'] service = api_user['client']
if (service != current_app.config.get('ADMIN_CLIENT_USER_NAME') and admin_users = [current_app.config.get('ADMIN_CLIENT_USER_NAME'),
current_app.config.get('DELIVERY_CLIENT_USER_NAME')]
if (service not in admin_users and
template.service != models.Service.query.filter_by(id=service).first()): template.service != models.Service.query.filter_by(id=service).first()):
raise ValidationError('Invalid template', 'restricted') raise ValidationError('Invalid template', 'restricted')