darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 18:31:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2427 from alphagov/fix-date-bug-for-performance-platform

Browse Source 
Fix date bug for performance platform
This commit is contained in:
Rebecca Law
2019-04-01 12:16:31 +01:00
committed by GitHub
parent 814d9bee99 fb398876ee
commit 020eb76f73
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/nightly_tasks.py
View File

@@ -157,7 +157,7 @@ def send_daily_performance_platform_stats():
def send_total_sent_notifications_to_performance_platform(day): def send_total_sent_notifications_to_performance_platform(day):
count_dict = total_sent_notifications.get_total_sent_notifications_for_day(day) count_dict = total_sent_notifications.get_total_sent_notifications_for_day(day.date())
email_sent_count = count_dict.get('email').get('count') email_sent_count = count_dict.get('email').get('count')
sms_sent_count = count_dict.get('sms').get('count') sms_sent_count = count_dict.get('sms').get('count')
letter_sent_count = count_dict.get('letter').get('count') letter_sent_count = count_dict.get('letter').get('count')

7
tests/app/celery/test_nightly_tasks.py
View File

@@ -261,7 +261,7 @@ def test_send_total_sent_notifications_to_performance_platform_calls_with_correc
perf_mock = mocker.patch( perf_mock = mocker.patch(
'app.celery.nightly_tasks.total_sent_notifications.send_total_notifications_sent_for_day_stats') # noqa 'app.celery.nightly_tasks.total_sent_notifications.send_total_notifications_sent_for_day_stats') # noqa
today = datetime.utcnow().date() today = datetime.utcnow()
create_ft_notification_status(bst_date=today, notification_type='sms', service=sample_template.service, create_ft_notification_status(bst_date=today, notification_type='sms', service=sample_template.service,
template=sample_template) template=sample_template)
create_ft_notification_status(bst_date=today, notification_type='email', service=sample_email_template.service, create_ft_notification_status(bst_date=today, notification_type='email', service=sample_email_template.service,
@@ -283,8 +283,9 @@ def test_send_total_sent_notifications_to_performance_platform_calls_with_correc
send_total_sent_notifications_to_performance_platform(yesterday) send_total_sent_notifications_to_performance_platform(yesterday)
perf_mock.assert_has_calls([ perf_mock.assert_has_calls([
call(yesterday, 'sms', 2), call(yesterday.date(), 'sms', 2),
call(yesterday, 'email', 3) call(yesterday.date(), 'email', 3),
call(yesterday.date(), 'letter', 0)
]) ])