darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

use a contextmanager to set config values

Browse Source 
so that when later tests run, the config has been restored to its
defaults and we don't end up failing later tests in confusing ways
This commit is contained in:
Leo Hemsted
2016-09-21 17:13:26 +01:00
parent 24903a19ef
commit 00b905bef0
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/app/job/test_rest.py
View File

@@ -8,6 +8,7 @@ import pytz
import app.celery.tasks
from tests import create_authorization_header
from tests.conftest import set_config
from tests.app.conftest import (
sample_job as create_job,
sample_notification as create_notification
@@ -612,11 +613,11 @@ def test_get_jobs_should_paginate(
):
create_10_jobs(notify_db, notify_db_session, sample_template.service, sample_template)
client.application.config['PAGE_SIZE'] = 2
path = '/service/{}/job'.format(sample_template.service_id)
auth_header = create_authorization_header(service_id=str(sample_template.service_id))
response = client.get(path, headers=[auth_header])
with set_config(client.application, 'PAGE_SIZE', 2):
response = client.get(path, headers=[auth_header])
assert response.status_code == 200
resp_json = json.loads(response.get_data(as_text=True))
@@ -637,11 +638,11 @@ def test_get_jobs_accepts_page_parameter(
):
create_10_jobs(notify_db, notify_db_session, sample_template.service, sample_template)
client.application.config['PAGE_SIZE'] = 2
path = '/service/{}/job'.format(sample_template.service_id)
auth_header = create_authorization_header(service_id=str(sample_template.service_id))
response = client.get(path, headers=[auth_header], query_string={'page': 2})
with set_config(client.application, 'PAGE_SIZE', 2):
response = client.get(path, headers=[auth_header], query_string={'page': 2})
assert response.status_code == 200
resp_json = json.loads(response.get_data(as_text=True))