darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-05-04 00:00:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor the sms sender code to remove any unused methods.

Browse Source 
Refactor tests/db/create_service() to behave more like the real world.
Created new create_service_with_inbound_number and create_service_with_defined_sms_sender() test/db methods.
This commit is contained in:
Rebecca Law
2017-11-07 14:26:18 +00:00
parent 430342b567
commit 0054361044
15 changed files with 224 additions and 379 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/test_model.py
View File

@@ -30,7 +30,6 @@ from tests.app.db import (
create_reply_to_email,
create_letter_contact
)
from tests.conftest import set_config
@pytest.mark.parametrize('mobile_number', [
@@ -256,8 +255,7 @@ def test_inbound_number_returns_inbound_number(client, notify_db_session):
def test_inbound_number_returns_none_when_no_inbound_number(client, notify_db_session):
with set_config(client.application, 'FROM_NUMBER', 'test'):
service = create_service(sms_sender=None)
service = create_service()
assert not service.get_inbound_number()
@@ -275,5 +273,5 @@ def test_service_get_default_contact_letter(sample_service):
def test_service_get_default_sms_sender(notify_db_session):
service = create_service(sms_sender='new_value')
assert service.get_default_sms_sender() == 'new_value'
service = create_service()
assert service.get_default_sms_sender() == 'testing'