darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor the sms sender code to remove any unused methods.

Browse Source 
Refactor tests/db/create_service() to behave more like the real world.
Created new create_service_with_inbound_number and create_service_with_defined_sms_sender() test/db methods.
This commit is contained in:
Rebecca Law
2017-11-07 14:26:18 +00:00
parent 430342b567
commit 0054361044
15 changed files with 224 additions and 379 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/app/inbound_sms/test_rest.py
View File

@@ -5,7 +5,7 @@ from flask import json
from freezegun import freeze_time
from tests import create_authorization_header
from tests.app.db import create_inbound_sms, create_service
from tests.app.db import create_inbound_sms, create_service, create_service_with_inbound_number
def test_get_inbound_sms_with_no_params(client, sample_service):
@@ -273,17 +273,18 @@ def test_get_inbound_sms_summary_with_no_inbound(admin_request, sample_service):
}
def test_get_inbound_sms_by_id_returns_200(admin_request, sample_service):
inbound = create_inbound_sms(sample_service, user_number='447700900001')
def test_get_inbound_sms_by_id_returns_200(admin_request, notify_db_session):
service = create_service_with_inbound_number(inbound_number='12345')
inbound = create_inbound_sms(service=service, user_number='447700900001')
response = admin_request.get(
'inbound_sms.get_inbound_by_id',
service_id=sample_service.id,
service_id=service.id,
inbound_sms_id=inbound.id,
)
assert response['user_number'] == '447700900001'
assert response['service_id'] == str(sample_service.id)
assert response['service_id'] == str(service.id)
def test_get_inbound_sms_by_id_invalid_id_returns_404(admin_request, sample_service):