setup.cfg

[tool:pytest]
xfail_strict=true


[flake8]
exclude = venv*,__pycache__,node_modules,cache,migrations,build
# W504 line break after binary operator
extend_ignore=B306, W504
select=B901
make xpass fail the test run 2017-02-23 16:50:04 +00:00			`[tool:pytest]`
			`xfail_strict=true`
bump requirements, fix pyflake8 things, unpin botocore/awscli 2018-11-07 13:39:08 +00:00

			`[flake8]`
Move flake8 config into setup.cfg At the moment the two are duplicative, and it’s not clear which takes precedence. We need to keep the `excludes` line otherwise running the `flake8` command takes ~3 times longer and may lint 3rd party files that we don’t control. 2020-12-23 12:23:15 +00:00			`exclude = venv*,__pycache__,node_modules,cache,migrations,build`
bump requirements, fix pyflake8 things, unpin botocore/awscli 2018-11-07 13:39:08 +00:00			`# W504 line break after binary operator`
Do extra code style checks with flake8-bugbear Flake8 Bugbear checks for some extra things that aren’t code style errors, but are likely to introduce bugs or unexpected behaviour. A good example is having mutable default function arguments, which get shared between every call to the function and therefore mutating a value in one place can unexpectedly cause it to change in another. This commit enables all the extra warnings provided by Flake8 Bugbear, except for: - the line length one (because we already lint for that separately) - B903 Data class should either be immutable or use `__slots__` because this seems to false-positive on some of our custom exceptions - B902 Invalid first argument 'cls' used for instance method because some SQLAlchemy decorators (eg `declared_attr`) make things that aren’t formally class methods take a class not an instance as their first argument It disables: - _B306: BaseException.message is removed in Python 3_ because I think our exceptions have a custom structure that means the `.message` attribute is still present Matches the work done in other repos: - https://github.com/alphagov/notifications-admin/pull/3172/files 2020-12-22 15:46:31 +00:00			`extend_ignore=B306, W504`
			`select=B901`