darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-12 16:22:17 -05:00
Code Issues Packages Projects Releases Wiki Activity
Files
eb6572640c821fa1c08c914b35380531fd4ee0e5
notifications-api/app/webauthn/webauthn_schema.py

24 lines
822 B
Python
Raw Normal View History

add webauthn crud endpoints added some simple validation to the delete endpoint for sanity, but generally my assumption is that more validation will happen on the admin side. noteably im not checking whether the credentials are duplicated, nor is there a uniqueness constraint in the database - I'm not sure if the credential blob will always reliably be equivalent, and I believe the browser should hopefully take care of dupes.
2021-05-10 22:09:07 +01:00
post_create_webauthn_credential_schema = {
"$schema": "http://json-schema.org/draft-07/schema#",
"description": "POST webauthn_credential schema",
"type": "object",
"properties": {
tweak webauthn rest errors simplify logic by changing the dao function to require a user id and a webauthn cred id. Note that this changes the response from a 400 to a 404 if the cred is for a different user than the supplied id. give a minimum length to the text fields in POSTS to create/update a credential to avoid surprising unexpected edge cases involving empty string names etc.
2021-05-12 15:34:37 +01:00
"name": {"type": "string", "minLength": 1},
"credential_data": {"type": "string", "minLength": 1},
"registration_response": {"type": "string", "minLength": 1},
add webauthn crud endpoints added some simple validation to the delete endpoint for sanity, but generally my assumption is that more validation will happen on the admin side. noteably im not checking whether the credentials are duplicated, nor is there a uniqueness constraint in the database - I'm not sure if the credential blob will always reliably be equivalent, and I believe the browser should hopefully take care of dupes.
2021-05-10 22:09:07 +01:00
},
"required": ["name", "credential_data", "registration_response"],
reformat
2023-08-29 14:54:30 -07:00
"additionalProperties": False,
add webauthn crud endpoints added some simple validation to the delete endpoint for sanity, but generally my assumption is that more validation will happen on the admin side. noteably im not checking whether the credentials are duplicated, nor is there a uniqueness constraint in the database - I'm not sure if the credential blob will always reliably be equivalent, and I believe the browser should hopefully take care of dupes.
2021-05-10 22:09:07 +01:00
}
post_update_webauthn_credential_schema = {
"$schema": "http://json-schema.org/draft-07/schema#",
"description": "POST update webauthn_credential schema",
"type": "object",
"properties": {
tweak webauthn rest errors simplify logic by changing the dao function to require a user id and a webauthn cred id. Note that this changes the response from a 400 to a 404 if the cred is for a different user than the supplied id. give a minimum length to the text fields in POSTS to create/update a credential to avoid surprising unexpected edge cases involving empty string names etc.
2021-05-12 15:34:37 +01:00
"name": {"type": "string", "minLength": 1},
add webauthn crud endpoints added some simple validation to the delete endpoint for sanity, but generally my assumption is that more validation will happen on the admin side. noteably im not checking whether the credentials are duplicated, nor is there a uniqueness constraint in the database - I'm not sure if the credential blob will always reliably be equivalent, and I believe the browser should hopefully take care of dupes.
2021-05-10 22:09:07 +01:00
},
"required": ["name"],
reformat
2023-08-29 14:54:30 -07:00
"additionalProperties": False,
add webauthn crud endpoints added some simple validation to the delete endpoint for sanity, but generally my assumption is that more validation will happen on the admin side. noteably im not checking whether the credentials are duplicated, nor is there a uniqueness constraint in the database - I'm not sure if the credential blob will always reliably be equivalent, and I believe the browser should hopefully take care of dupes.
2021-05-10 22:09:07 +01:00
}
Reference in New Issue Copy Permalink