tests/app/db.py

from app.models import User
from app.dao.users_dao import save_model_user


def create_user(mobile_number="+447700900986", email="notify@digital.cabinet-office.gov.uk"):
    data = {
        'name': 'Test User',
        'email_address': email,
        'password': 'password',
        'mobile_number': mobile_number,
        'state': 'active'
    }
    user = User.query.filter_by(email_address=email).first()
    if not user:
        user = User(**data)
    save_model_user(user)
    return user
refactor sample_user to create a new create_user function this create_user function can be imported for use in creating specific users in your tests, for example ``` from tests.app.db import create_user def test_create_user_persists_to_database(notify_db_session): user = create_user() assert User.query.count() == 1 ``` this has the benefit of not requiring you to pass the notify_db and notify_db_session fixtures around, and separating custom object creation from the fixture dependency trees to aid clarity I started with sample_user since it has no downstream dependencies, but the intention is to push this out to all db fixtures eventually. This is a total conversion, but can be rolled out in a non-breaking manner by keeping arguments in the fixture, and passing them through to the new db function - then tests can be updated to use the create_* instead of sample_* functions as and when you want to 2016-12-28 12:30:21 +00:00			`from app.models import User`
			`from app.dao.users_dao import save_model_user`


			`def create_user(mobile_number="+447700900986", email="notify@digital.cabinet-office.gov.uk"):`
			`data = {`
			`'name': 'Test User',`
			`'email_address': email,`
			`'password': 'password',`
			`'mobile_number': mobile_number,`
			`'state': 'active'`
			`}`
remove pytest.mark.usefixtures decorator while it's nice to use the decorator to signify fixtures with side effects, it has unfortunate problems of completely overriding any fixtures you've declared in the funcargs - so isn't really suitable for our usecase where we often have other fixtures we rely on to return values to us. So for consistency, let's remove this and stick to using funcargs to define our fixtures 2017-01-10 15:00:10 +00:00			`user = User.query.filter_by(email_address=email).first()`
			`if not user:`
			`user = User(**data)`
			`save_model_user(user)`
			`return user`