2021-06-21 16:03:24 +01:00
|
|
|
|
from datetime import datetime
|
2021-03-10 13:55:06 +00:00
|
|
|
|
|
2016-10-25 18:04:03 +01:00
|
|
|
|
import pytest
|
2017-04-25 09:54:09 +01:00
|
|
|
|
from flask import current_app
|
2021-03-10 13:55:06 +00:00
|
|
|
|
from freezegun import freeze_time
|
2018-08-16 16:25:58 +01:00
|
|
|
|
from notifications_utils import SMS_CHAR_COUNT_LIMIT
|
2017-12-04 11:12:26 +00:00
|
|
|
|
|
2016-11-11 16:47:52 +00:00
|
|
|
|
import app
|
2019-11-08 13:44:27 +00:00
|
|
|
|
from app.dao import templates_dao
|
2021-03-10 13:55:06 +00:00
|
|
|
|
from app.models import EMAIL_TYPE, INTERNATIONAL_LETTERS, LETTER_TYPE, SMS_TYPE
|
|
|
|
|
|
from app.notifications.process_notifications import (
|
|
|
|
|
|
create_content_for_notification,
|
2020-07-29 14:52:18 +01:00
|
|
|
|
)
|
2016-11-11 16:47:52 +00:00
|
|
|
|
from app.notifications.validators import (
|
2020-02-25 16:11:53 +00:00
|
|
|
|
check_if_service_can_send_files_by_email,
|
2021-03-10 13:55:06 +00:00
|
|
|
|
check_is_message_too_long,
|
2019-11-19 17:05:50 +00:00
|
|
|
|
check_notification_content_is_not_empty,
|
2021-06-21 16:03:24 +01:00
|
|
|
|
check_rate_limiting,
|
2021-03-10 13:55:06 +00:00
|
|
|
|
check_reply_to,
|
2017-10-30 13:36:49 +00:00
|
|
|
|
check_service_email_reply_to_id,
|
2017-12-15 16:51:40 +00:00
|
|
|
|
check_service_letter_contact_id,
|
2021-03-10 13:55:06 +00:00
|
|
|
|
check_service_over_api_rate_limit,
|
|
|
|
|
|
check_service_over_daily_message_limit,
|
|
|
|
|
|
check_service_sms_sender_id,
|
|
|
|
|
|
check_template_is_active,
|
|
|
|
|
|
check_template_is_for_notification_type,
|
2019-11-19 17:05:50 +00:00
|
|
|
|
service_can_send_to_recipient,
|
2020-07-29 14:52:18 +01:00
|
|
|
|
validate_address,
|
2019-11-19 17:05:50 +00:00
|
|
|
|
validate_and_format_recipient,
|
2020-03-04 17:04:11 +00:00
|
|
|
|
validate_template,
|
2017-12-15 16:51:40 +00:00
|
|
|
|
)
|
2021-03-10 13:55:06 +00:00
|
|
|
|
from app.serialised_models import (
|
|
|
|
|
|
SerialisedAPIKeyCollection,
|
|
|
|
|
|
SerialisedService,
|
|
|
|
|
|
SerialisedTemplate,
|
|
|
|
|
|
)
|
2020-03-04 17:04:11 +00:00
|
|
|
|
from app.utils import get_template_instance
|
2021-03-10 13:55:06 +00:00
|
|
|
|
from app.v2.errors import BadRequestError, RateLimitError, TooManyRequestsError
|
2019-10-31 15:02:30 +00:00
|
|
|
|
from tests.app.db import (
|
|
|
|
|
|
create_api_key,
|
|
|
|
|
|
create_letter_contact,
|
|
|
|
|
|
create_reply_to_email,
|
|
|
|
|
|
create_service,
|
2020-07-28 11:22:19 +01:00
|
|
|
|
create_service_guest_list,
|
2021-03-10 13:55:06 +00:00
|
|
|
|
create_service_sms_sender,
|
2019-10-31 15:02:30 +00:00
|
|
|
|
create_template,
|
|
|
|
|
|
)
|
2021-03-10 13:55:06 +00:00
|
|
|
|
from tests.conftest import set_config
|
2016-10-25 18:04:03 +01:00
|
|
|
|
|
|
|
|
|
|
|
2017-12-04 11:12:26 +00:00
|
|
|
|
# all of these tests should have redis enabled (except where we specifically disable it)
|
|
|
|
|
|
@pytest.fixture(scope='module', autouse=True)
|
|
|
|
|
|
def enable_redis(notify_api):
|
|
|
|
|
|
with set_config(notify_api, 'REDIS_ENABLED', True):
|
|
|
|
|
|
yield
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-21 16:03:24 +01:00
|
|
|
|
@pytest.mark.parametrize('key_type', ['team', 'normal'])
|
2016-11-11 16:47:52 +00:00
|
|
|
|
def test_check_service_message_limit_in_cache_under_message_limit_passes(
|
|
|
|
|
|
key_type,
|
|
|
|
|
|
sample_service,
|
|
|
|
|
|
mocker):
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
2021-06-29 13:48:38 +01:00
|
|
|
|
mock_get = mocker.patch('app.notifications.validators.redis_store.get', return_value="1")
|
2021-06-21 16:03:24 +01:00
|
|
|
|
mock_set = mocker.patch('app.notifications.validators.redis_store.set')
|
2021-06-29 12:59:20 +01:00
|
|
|
|
service_stats = check_service_over_daily_message_limit(key_type, serialised_service)
|
|
|
|
|
|
assert service_stats == 1
|
2021-06-21 16:03:24 +01:00
|
|
|
|
mock_get.assert_called_once_with(f'{serialised_service.id}-{datetime.utcnow().strftime("%Y-%m-%d")}-count')
|
2021-06-28 10:12:43 +01:00
|
|
|
|
mock_set.assert_not_called()
|
2016-11-11 16:47:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_check_service_over_daily_message_limit_should_not_interact_with_cache_for_test_key(sample_service, mocker):
|
2016-11-11 16:47:52 +00:00
|
|
|
|
mocker.patch('app.notifications.validators.redis_store')
|
2021-06-21 16:03:24 +01:00
|
|
|
|
mock_get = mocker.patch('app.notifications.validators.redis_store.get', side_effect=[None])
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
2021-06-29 12:59:20 +01:00
|
|
|
|
service_stats = check_service_over_daily_message_limit('test', serialised_service)
|
|
|
|
|
|
assert service_stats == 0
|
2021-06-24 11:05:22 +01:00
|
|
|
|
mock_get.assert_not_called()
|
2016-11-11 16:47:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('key_type', ['team', 'normal'])
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_check_service_over_daily_message_limit_should_set_cache_value_as_zero_if_cache_not_set(
|
2016-11-11 16:47:52 +00:00
|
|
|
|
key_type,
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_template,
|
2016-11-11 16:47:52 +00:00
|
|
|
|
sample_service,
|
|
|
|
|
|
mocker
|
|
|
|
|
|
):
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
2016-11-11 16:47:52 +00:00
|
|
|
|
with freeze_time("2016-01-01 12:00:00.000000"):
|
|
|
|
|
|
mocker.patch('app.notifications.validators.redis_store.set')
|
2021-06-29 12:59:20 +01:00
|
|
|
|
service_stats = check_service_over_daily_message_limit(key_type, serialised_service)
|
2016-11-11 16:47:52 +00:00
|
|
|
|
app.notifications.validators.redis_store.set.assert_called_with(
|
2021-06-21 16:03:24 +01:00
|
|
|
|
str(sample_service.id) + "-2016-01-01-count", 0, ex=86400
|
2016-11-11 16:47:52 +00:00
|
|
|
|
)
|
2021-06-29 12:59:20 +01:00
|
|
|
|
assert service_stats == 0
|
2016-11-11 16:47:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_check_service_over_daily_message_limit_does_nothing_if_redis_disabled(notify_api, sample_service, mocker):
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
2017-12-04 11:12:26 +00:00
|
|
|
|
with set_config(notify_api, 'REDIS_ENABLED', False):
|
2021-06-21 16:03:24 +01:00
|
|
|
|
mock_cache_key = mocker.patch('notifications_utils.clients.redis.daily_limit_cache_key')
|
2021-06-29 12:59:20 +01:00
|
|
|
|
service_stats = check_service_over_daily_message_limit('normal', serialised_service)
|
|
|
|
|
|
assert service_stats == 0
|
2021-06-21 16:03:24 +01:00
|
|
|
|
assert mock_cache_key.method_calls == []
|
2017-12-04 11:12:26 +00:00
|
|
|
|
|
|
|
|
|
|
|
2016-11-11 16:47:52 +00:00
|
|
|
|
@pytest.mark.parametrize('key_type', ['team', 'normal'])
|
2021-06-21 16:03:24 +01:00
|
|
|
|
def test_check_service_message_limit_over_message_limit_fails(key_type, mocker, notify_db_session):
|
2021-06-28 10:12:43 +01:00
|
|
|
|
service = create_service(message_limit=4)
|
2021-06-29 13:48:38 +01:00
|
|
|
|
mocker.patch('app.redis_store.get', return_value="5")
|
2021-06-21 16:03:24 +01:00
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
with pytest.raises(TooManyRequestsError) as e:
|
|
|
|
|
|
check_service_over_daily_message_limit(key_type, service)
|
|
|
|
|
|
assert e.value.status_code == 429
|
|
|
|
|
|
assert e.value.message == 'Exceeded send limits (4) for today'
|
|
|
|
|
|
assert e.value.fields == []
|
2016-10-25 18:04:03 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('template_type, notification_type',
|
2017-06-27 12:00:39 +01:00
|
|
|
|
[(EMAIL_TYPE, EMAIL_TYPE),
|
|
|
|
|
|
(SMS_TYPE, SMS_TYPE)])
|
2016-10-25 18:04:03 +01:00
|
|
|
|
def test_check_template_is_for_notification_type_pass(template_type, notification_type):
|
|
|
|
|
|
assert check_template_is_for_notification_type(notification_type=notification_type,
|
|
|
|
|
|
template_type=template_type) is None
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('template_type, notification_type',
|
2017-06-27 12:00:39 +01:00
|
|
|
|
[(SMS_TYPE, EMAIL_TYPE),
|
|
|
|
|
|
(EMAIL_TYPE, SMS_TYPE)])
|
2016-10-25 18:04:03 +01:00
|
|
|
|
def test_check_template_is_for_notification_type_fails_when_template_type_does_not_match_notification_type(
|
|
|
|
|
|
template_type, notification_type):
|
2016-10-31 12:22:26 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2016-10-25 18:04:03 +01:00
|
|
|
|
check_template_is_for_notification_type(notification_type=notification_type,
|
|
|
|
|
|
template_type=template_type)
|
2016-11-11 10:50:38 +00:00
|
|
|
|
assert e.value.status_code == 400
|
2016-10-31 12:22:26 +00:00
|
|
|
|
error_message = '{0} template is not suitable for {1} notification'.format(template_type, notification_type)
|
|
|
|
|
|
assert e.value.message == error_message
|
|
|
|
|
|
assert e.value.fields == [{'template': error_message}]
|
2016-10-25 18:04:03 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_template_is_active_passes(sample_template):
|
|
|
|
|
|
assert check_template_is_active(sample_template) is None
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-28 17:10:00 +01:00
|
|
|
|
def test_check_template_is_active_fails(sample_template):
|
2016-10-25 18:04:03 +01:00
|
|
|
|
sample_template.archived = True
|
|
|
|
|
|
from app.dao.templates_dao import dao_update_template
|
|
|
|
|
|
dao_update_template(sample_template)
|
2016-10-31 12:22:26 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2016-10-25 18:04:03 +01:00
|
|
|
|
check_template_is_active(sample_template)
|
2016-10-31 12:22:26 +00:00
|
|
|
|
assert e.value.status_code == 400
|
|
|
|
|
|
assert e.value.message == 'Template has been deleted'
|
|
|
|
|
|
assert e.value.fields == [{'template': 'Template has been deleted'}]
|
2016-10-27 11:46:37 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('key_type',
|
|
|
|
|
|
['test', 'normal'])
|
2019-10-31 15:02:30 +00:00
|
|
|
|
def test_service_can_send_to_recipient_passes(key_type, notify_db_session):
|
|
|
|
|
|
trial_mode_service = create_service(service_name='trial mode', restricted=True)
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(trial_mode_service.id)
|
2016-10-27 11:46:37 +01:00
|
|
|
|
assert service_can_send_to_recipient(trial_mode_service.users[0].email_address,
|
|
|
|
|
|
key_type,
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service) is None
|
2016-10-27 11:46:37 +01:00
|
|
|
|
assert service_can_send_to_recipient(trial_mode_service.users[0].mobile_number,
|
|
|
|
|
|
key_type,
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service) is None
|
2016-10-27 11:46:37 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('key_type',
|
|
|
|
|
|
['test', 'normal'])
|
2019-10-31 15:02:30 +00:00
|
|
|
|
def test_service_can_send_to_recipient_passes_for_live_service_non_team_member(key_type, sample_service):
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
2016-10-27 11:46:37 +01:00
|
|
|
|
assert service_can_send_to_recipient("some_other_email@test.com",
|
|
|
|
|
|
key_type,
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service) is None
|
2016-10-27 11:46:37 +01:00
|
|
|
|
assert service_can_send_to_recipient('07513332413',
|
|
|
|
|
|
key_type,
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service) is None
|
2016-10-27 11:46:37 +01:00
|
|
|
|
|
|
|
|
|
|
|
2020-07-28 11:22:19 +01:00
|
|
|
|
def test_service_can_send_to_recipient_passes_for_guest_list_recipient_passes(sample_service):
|
|
|
|
|
|
create_service_guest_list(sample_service, email_address="some_other_email@test.com")
|
2016-10-27 11:46:37 +01:00
|
|
|
|
assert service_can_send_to_recipient("some_other_email@test.com",
|
2016-11-01 10:33:34 +00:00
|
|
|
|
'team',
|
2016-10-28 17:10:00 +01:00
|
|
|
|
sample_service) is None
|
2020-07-28 11:22:19 +01:00
|
|
|
|
create_service_guest_list(sample_service, mobile_number='07513332413')
|
2016-10-27 11:46:37 +01:00
|
|
|
|
assert service_can_send_to_recipient('07513332413',
|
2016-11-01 10:33:34 +00:00
|
|
|
|
'team',
|
2016-10-28 17:10:00 +01:00
|
|
|
|
sample_service) is None
|
2016-10-27 11:46:37 +01:00
|
|
|
|
|
|
|
|
|
|
|
2018-01-17 15:20:04 +00:00
|
|
|
|
@pytest.mark.parametrize('recipient', [
|
|
|
|
|
|
{"email_address": "some_other_email@test.com"},
|
|
|
|
|
|
{"mobile_number": "07513332413"},
|
|
|
|
|
|
])
|
2020-07-28 11:22:19 +01:00
|
|
|
|
def test_service_can_send_to_recipient_fails_when_ignoring_guest_list(
|
2018-01-17 15:20:04 +00:00
|
|
|
|
notify_db,
|
|
|
|
|
|
notify_db_session,
|
|
|
|
|
|
sample_service,
|
|
|
|
|
|
recipient,
|
|
|
|
|
|
):
|
2020-07-28 11:22:19 +01:00
|
|
|
|
create_service_guest_list(sample_service, **recipient)
|
2018-01-17 15:20:04 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as exec_info:
|
|
|
|
|
|
service_can_send_to_recipient(
|
|
|
|
|
|
next(iter(recipient.values())),
|
|
|
|
|
|
'team',
|
|
|
|
|
|
sample_service,
|
2020-07-28 10:19:46 +01:00
|
|
|
|
allow_guest_list_recipients=False,
|
2018-01-17 15:20:04 +00:00
|
|
|
|
)
|
|
|
|
|
|
assert exec_info.value.status_code == 400
|
|
|
|
|
|
assert exec_info.value.message == 'Can’t send to this recipient using a team-only API key'
|
|
|
|
|
|
assert exec_info.value.fields == []
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-31 12:22:26 +00:00
|
|
|
|
@pytest.mark.parametrize('recipient', ['07513332413', 'some_other_email@test.com'])
|
|
|
|
|
|
@pytest.mark.parametrize('key_type, error_message',
|
|
|
|
|
|
[('team', 'Can’t send to this recipient using a team-only API key'),
|
|
|
|
|
|
('normal',
|
|
|
|
|
|
"Can’t send to this recipient when service is in trial mode – see https://www.notifications.service.gov.uk/trial-mode")]) # noqa
|
2019-10-31 15:02:30 +00:00
|
|
|
|
def test_service_can_send_to_recipient_fails_when_recipient_is_not_on_team(
|
|
|
|
|
|
recipient,
|
|
|
|
|
|
key_type,
|
|
|
|
|
|
error_message,
|
|
|
|
|
|
notify_db_session,
|
|
|
|
|
|
):
|
|
|
|
|
|
trial_mode_service = create_service(service_name='trial mode', restricted=True)
|
2016-10-31 12:22:26 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as exec_info:
|
2016-11-01 10:33:34 +00:00
|
|
|
|
service_can_send_to_recipient(recipient,
|
|
|
|
|
|
key_type,
|
|
|
|
|
|
trial_mode_service)
|
2016-10-31 12:22:26 +00:00
|
|
|
|
assert exec_info.value.status_code == 400
|
|
|
|
|
|
assert exec_info.value.message == error_message
|
|
|
|
|
|
assert exec_info.value.fields == []
|
2016-10-27 11:46:37 +01:00
|
|
|
|
|
|
|
|
|
|
|
2019-10-31 15:02:30 +00:00
|
|
|
|
def test_service_can_send_to_recipient_fails_when_mobile_number_is_not_on_team(sample_service):
|
2016-10-31 12:22:26 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2016-11-01 10:33:34 +00:00
|
|
|
|
service_can_send_to_recipient("0758964221",
|
|
|
|
|
|
'team',
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_service)
|
2016-10-31 12:22:26 +00:00
|
|
|
|
assert e.value.status_code == 400
|
|
|
|
|
|
assert e.value.message == 'Can’t send to this recipient using a team-only API key'
|
|
|
|
|
|
assert e.value.fields == []
|
2016-10-27 11:46:37 +01:00
|
|
|
|
|
|
|
|
|
|
|
2020-04-24 15:43:37 +01:00
|
|
|
|
@pytest.mark.parametrize('char_count', [612, 0, 494, 200, 918])
|
2020-03-04 17:04:11 +00:00
|
|
|
|
@pytest.mark.parametrize('show_prefix', [True, False])
|
|
|
|
|
|
@pytest.mark.parametrize('template_type', ['sms', 'email', 'letter'])
|
2020-11-09 15:19:00 +00:00
|
|
|
|
def test_check_is_message_too_long_passes(notify_db_session, show_prefix, char_count, template_type):
|
2020-03-04 17:04:11 +00:00
|
|
|
|
service = create_service(prefix_sms=show_prefix)
|
|
|
|
|
|
t = create_template(service=service, content='a' * char_count, template_type=template_type)
|
|
|
|
|
|
template = templates_dao.dao_get_template_by_id_and_service_id(template_id=t.id, service_id=service.id)
|
|
|
|
|
|
template_with_content = get_template_instance(template=template.__dict__, values={})
|
2020-11-09 15:19:00 +00:00
|
|
|
|
assert check_is_message_too_long(template_with_content) is None
|
2016-10-27 11:46:37 +01:00
|
|
|
|
|
|
|
|
|
|
|
2020-04-24 15:43:37 +01:00
|
|
|
|
@pytest.mark.parametrize('char_count', [919, 6000])
|
2020-03-04 17:04:11 +00:00
|
|
|
|
@pytest.mark.parametrize('show_prefix', [True, False])
|
2020-11-09 15:19:00 +00:00
|
|
|
|
def test_check_is_message_too_long_fails(notify_db_session, show_prefix, char_count):
|
2016-10-31 12:22:26 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2020-03-04 17:04:11 +00:00
|
|
|
|
service = create_service(prefix_sms=show_prefix)
|
|
|
|
|
|
t = create_template(service=service, content='a' * char_count, template_type='sms')
|
|
|
|
|
|
template = templates_dao.dao_get_template_by_id_and_service_id(template_id=t.id, service_id=service.id)
|
|
|
|
|
|
template_with_content = get_template_instance(template=template.__dict__, values={})
|
2020-11-09 15:19:00 +00:00
|
|
|
|
check_is_message_too_long(template_with_content)
|
2016-10-31 12:22:26 +00:00
|
|
|
|
assert e.value.status_code == 400
|
2020-11-09 15:19:00 +00:00
|
|
|
|
expected_message = f'Your message is too long. '\
|
|
|
|
|
|
f'Text messages cannot be longer than {SMS_CHAR_COUNT_LIMIT} characters. '\
|
|
|
|
|
|
f'Your message is {char_count} characters long.'
|
|
|
|
|
|
assert e.value.message == expected_message
|
2016-10-31 12:22:26 +00:00
|
|
|
|
assert e.value.fields == []
|
2017-04-24 14:15:08 +01:00
|
|
|
|
|
|
|
|
|
|
|
2020-11-09 15:19:00 +00:00
|
|
|
|
def test_check_is_message_too_long_passes_for_long_email(sample_service):
|
2020-12-18 15:10:45 +00:00
|
|
|
|
email_character_count = 2_000_001
|
2020-11-09 15:19:00 +00:00
|
|
|
|
t = create_template(service=sample_service, content='a' * email_character_count, template_type='email')
|
2020-03-04 17:04:11 +00:00
|
|
|
|
template = templates_dao.dao_get_template_by_id_and_service_id(template_id=t.id,
|
|
|
|
|
|
service_id=t.service_id)
|
|
|
|
|
|
template_with_content = get_template_instance(template=template.__dict__, values={})
|
2020-11-09 15:19:00 +00:00
|
|
|
|
template_with_content.values
|
|
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
|
|
|
|
|
check_is_message_too_long(template_with_content)
|
|
|
|
|
|
assert e.value.status_code == 400
|
2020-12-07 15:15:50 +00:00
|
|
|
|
expected_message = (
|
|
|
|
|
|
'Your message is too long. ' +
|
2020-12-16 15:29:06 +00:00
|
|
|
|
'Emails cannot be longer than 2000000 bytes. ' +
|
2020-12-18 15:10:45 +00:00
|
|
|
|
'Your message is 2000001 bytes.'
|
2020-12-07 15:15:50 +00:00
|
|
|
|
)
|
2020-11-09 15:19:00 +00:00
|
|
|
|
assert e.value.message == expected_message
|
|
|
|
|
|
assert e.value.fields == []
|
2020-03-04 17:04:11 +00:00
|
|
|
|
|
|
|
|
|
|
|
2019-11-19 17:05:50 +00:00
|
|
|
|
def test_check_notification_content_is_not_empty_passes(notify_api, mocker, sample_service):
|
2019-11-08 13:44:27 +00:00
|
|
|
|
template_id = create_template(sample_service, content="Content is not empty").id
|
2020-06-22 10:20:53 +01:00
|
|
|
|
template = SerialisedTemplate.from_id_and_service_id(
|
2019-11-08 13:44:27 +00:00
|
|
|
|
template_id=template_id,
|
|
|
|
|
|
service_id=sample_service.id
|
|
|
|
|
|
)
|
|
|
|
|
|
template_with_content = create_content_for_notification(template, {})
|
2019-11-19 17:05:50 +00:00
|
|
|
|
assert check_notification_content_is_not_empty(template_with_content) is None
|
2019-11-08 13:44:27 +00:00
|
|
|
|
|
|
|
|
|
|
|
2019-11-19 17:05:50 +00:00
|
|
|
|
@pytest.mark.parametrize('template_content,notification_values', [
|
|
|
|
|
|
("", {}),
|
|
|
|
|
|
("((placeholder))", {"placeholder": ""})
|
|
|
|
|
|
])
|
|
|
|
|
|
def test_check_notification_content_is_not_empty_fails(
|
|
|
|
|
|
notify_api, mocker, sample_service, template_content, notification_values
|
|
|
|
|
|
):
|
|
|
|
|
|
template_id = create_template(sample_service, content=template_content).id
|
2020-06-22 10:20:53 +01:00
|
|
|
|
template = SerialisedTemplate.from_id_and_service_id(
|
2019-11-08 13:44:27 +00:00
|
|
|
|
template_id=template_id,
|
|
|
|
|
|
service_id=sample_service.id
|
|
|
|
|
|
)
|
2019-11-19 17:05:50 +00:00
|
|
|
|
template_with_content = create_content_for_notification(template, notification_values)
|
2019-11-08 13:44:27 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2019-11-19 17:05:50 +00:00
|
|
|
|
check_notification_content_is_not_empty(template_with_content)
|
2019-11-08 13:44:27 +00:00
|
|
|
|
assert e.value.status_code == 400
|
2019-11-21 15:48:43 +00:00
|
|
|
|
assert e.value.message == 'Your message is empty.'
|
2019-11-08 13:44:27 +00:00
|
|
|
|
assert e.value.fields == []
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-03-04 17:04:11 +00:00
|
|
|
|
def test_validate_template(sample_service):
|
|
|
|
|
|
template = create_template(sample_service, template_type="email")
|
|
|
|
|
|
validate_template(template.id, {}, sample_service, "email")
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-11-09 15:19:00 +00:00
|
|
|
|
@pytest.mark.parametrize("check_char_count", [True, False])
|
|
|
|
|
|
def test_validate_template_calls_all_validators(mocker, fake_uuid, sample_service, check_char_count):
|
2019-11-19 17:05:50 +00:00
|
|
|
|
template = create_template(sample_service, template_type="email")
|
|
|
|
|
|
mock_check_type = mocker.patch('app.notifications.validators.check_template_is_for_notification_type')
|
|
|
|
|
|
mock_check_if_active = mocker.patch('app.notifications.validators.check_template_is_active')
|
|
|
|
|
|
mock_create_conent = mocker.patch(
|
|
|
|
|
|
'app.notifications.validators.create_content_for_notification', return_value="content"
|
|
|
|
|
|
)
|
|
|
|
|
|
mock_check_not_empty = mocker.patch('app.notifications.validators.check_notification_content_is_not_empty')
|
2020-11-09 15:19:00 +00:00
|
|
|
|
mock_check_message_is_too_long = mocker.patch('app.notifications.validators.check_is_message_too_long')
|
|
|
|
|
|
template, template_with_content = validate_template(template.id, {}, sample_service, "email",
|
|
|
|
|
|
check_char_count=check_char_count
|
|
|
|
|
|
)
|
2019-11-19 17:05:50 +00:00
|
|
|
|
|
|
|
|
|
|
mock_check_type.assert_called_once_with("email", "email")
|
|
|
|
|
|
mock_check_if_active.assert_called_once_with(template)
|
|
|
|
|
|
mock_create_conent.assert_called_once_with(template, {})
|
|
|
|
|
|
mock_check_not_empty.assert_called_once_with("content")
|
2020-11-09 15:19:00 +00:00
|
|
|
|
if check_char_count:
|
|
|
|
|
|
mock_check_message_is_too_long.assert_called_once_with("content")
|
|
|
|
|
|
else:
|
|
|
|
|
|
assert not mock_check_message_is_too_long.called
|
2019-11-19 17:05:50 +00:00
|
|
|
|
|
|
|
|
|
|
|
2020-11-04 14:25:22 +00:00
|
|
|
|
def test_validate_template_calls_all_validators_exception_message_too_long(mocker, fake_uuid, sample_service):
|
|
|
|
|
|
template = create_template(sample_service, template_type="email")
|
|
|
|
|
|
mock_check_type = mocker.patch('app.notifications.validators.check_template_is_for_notification_type')
|
|
|
|
|
|
mock_check_if_active = mocker.patch('app.notifications.validators.check_template_is_active')
|
|
|
|
|
|
mock_create_conent = mocker.patch(
|
|
|
|
|
|
'app.notifications.validators.create_content_for_notification', return_value="content"
|
|
|
|
|
|
)
|
|
|
|
|
|
mock_check_not_empty = mocker.patch('app.notifications.validators.check_notification_content_is_not_empty')
|
2020-11-09 15:19:00 +00:00
|
|
|
|
mock_check_message_is_too_long = mocker.patch('app.notifications.validators.check_is_message_too_long')
|
2020-11-04 14:25:22 +00:00
|
|
|
|
template, template_with_content = validate_template(template.id, {}, sample_service, "email",
|
|
|
|
|
|
check_char_count=False)
|
|
|
|
|
|
|
|
|
|
|
|
mock_check_type.assert_called_once_with("email", "email")
|
|
|
|
|
|
mock_check_if_active.assert_called_once_with(template)
|
|
|
|
|
|
mock_create_conent.assert_called_once_with(template, {})
|
|
|
|
|
|
mock_check_not_empty.assert_called_once_with("content")
|
|
|
|
|
|
assert not mock_check_message_is_too_long.called
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-01-09 13:24:54 +00:00
|
|
|
|
@pytest.mark.parametrize('key_type', ['team', 'live', 'test'])
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_check_service_over_api_rate_limit_when_exceed_rate_limit_request_fails_raises_error(
|
2017-04-24 14:15:08 +01:00
|
|
|
|
key_type,
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_service,
|
2017-04-24 14:15:08 +01:00
|
|
|
|
mocker):
|
|
|
|
|
|
with freeze_time("2016-01-01 12:00:00.000000"):
|
|
|
|
|
|
|
|
|
|
|
|
if key_type == 'live':
|
|
|
|
|
|
api_key_type = 'normal'
|
|
|
|
|
|
else:
|
|
|
|
|
|
api_key_type = key_type
|
|
|
|
|
|
|
|
|
|
|
|
mocker.patch('app.redis_store.exceeded_rate_limit', return_value=True)
|
|
|
|
|
|
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_service.restricted = True
|
|
|
|
|
|
api_key = create_api_key(sample_service, key_type=api_key_type)
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
|
|
|
|
|
serialised_api_key = SerialisedAPIKeyCollection.from_service_id(serialised_service.id)[0]
|
2019-10-31 15:02:30 +00:00
|
|
|
|
|
2017-04-24 14:15:08 +01:00
|
|
|
|
with pytest.raises(RateLimitError) as e:
|
2020-06-26 13:38:58 +01:00
|
|
|
|
check_service_over_api_rate_limit(serialised_service, serialised_api_key)
|
2017-04-24 14:15:08 +01:00
|
|
|
|
|
|
|
|
|
|
assert app.redis_store.exceeded_rate_limit.called_with(
|
2019-10-31 15:02:30 +00:00
|
|
|
|
"{}-{}".format(str(sample_service.id), api_key.key_type),
|
|
|
|
|
|
sample_service.rate_limit,
|
2018-01-09 13:24:54 +00:00
|
|
|
|
60
|
2017-04-24 14:15:08 +01:00
|
|
|
|
)
|
|
|
|
|
|
assert e.value.status_code == 429
|
|
|
|
|
|
assert e.value.message == 'Exceeded rate limit for key type {} of {} requests per {} seconds'.format(
|
2019-10-31 15:02:30 +00:00
|
|
|
|
key_type.upper(), sample_service.rate_limit, 60
|
2017-04-24 14:15:08 +01:00
|
|
|
|
)
|
|
|
|
|
|
assert e.value.fields == []
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_check_service_over_api_rate_limit_when_rate_limit_has_not_exceeded_limit_succeeds(
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_service,
|
2017-04-24 14:15:08 +01:00
|
|
|
|
mocker):
|
|
|
|
|
|
with freeze_time("2016-01-01 12:00:00.000000"):
|
|
|
|
|
|
mocker.patch('app.redis_store.exceeded_rate_limit', return_value=False)
|
|
|
|
|
|
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_service.restricted = True
|
|
|
|
|
|
api_key = create_api_key(sample_service)
|
2020-06-26 13:38:58 +01:00
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
|
|
|
|
|
serialised_api_key = SerialisedAPIKeyCollection.from_service_id(serialised_service.id)[0]
|
2017-04-24 14:15:08 +01:00
|
|
|
|
|
2020-06-26 13:38:58 +01:00
|
|
|
|
check_service_over_api_rate_limit(serialised_service, serialised_api_key)
|
2017-04-24 14:15:08 +01:00
|
|
|
|
assert app.redis_store.exceeded_rate_limit.called_with(
|
2019-10-31 15:02:30 +00:00
|
|
|
|
"{}-{}".format(str(sample_service.id), api_key.key_type),
|
2018-01-09 13:24:54 +00:00
|
|
|
|
3000,
|
|
|
|
|
|
60
|
2017-04-24 14:15:08 +01:00
|
|
|
|
)
|
2017-04-25 09:54:09 +01:00
|
|
|
|
|
|
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_check_service_over_api_rate_limit_should_do_nothing_if_limiting_is_disabled(
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_service,
|
2017-04-25 09:54:09 +01:00
|
|
|
|
mocker):
|
|
|
|
|
|
with freeze_time("2016-01-01 12:00:00.000000"):
|
|
|
|
|
|
current_app.config['API_RATE_LIMIT_ENABLED'] = False
|
|
|
|
|
|
|
|
|
|
|
|
mocker.patch('app.redis_store.exceeded_rate_limit', return_value=False)
|
|
|
|
|
|
|
2019-10-31 15:02:30 +00:00
|
|
|
|
sample_service.restricted = True
|
2020-06-26 13:38:58 +01:00
|
|
|
|
create_api_key(sample_service)
|
|
|
|
|
|
serialised_service = SerialisedService.from_id(sample_service.id)
|
|
|
|
|
|
serialised_api_key = SerialisedAPIKeyCollection.from_service_id(serialised_service.id)[0]
|
2017-04-25 09:54:09 +01:00
|
|
|
|
|
2020-06-26 13:38:58 +01:00
|
|
|
|
check_service_over_api_rate_limit(serialised_service, serialised_api_key)
|
2021-06-24 11:05:22 +01:00
|
|
|
|
app.redis_store.exceeded_rate_limit.assert_not_called()
|
2021-06-21 16:03:24 +01:00
|
|
|
|
|
|
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_check_rate_limiting_validates_api_rate_limit_and_daily_limit(
|
2021-06-21 16:03:24 +01:00
|
|
|
|
notify_db_session, mocker
|
|
|
|
|
|
):
|
|
|
|
|
|
mock_rate_limit = mocker.patch('app.notifications.validators.check_service_over_api_rate_limit')
|
2021-06-24 11:05:22 +01:00
|
|
|
|
mock_daily_limit = mocker.patch('app.notifications.validators.check_service_over_daily_message_limit')
|
2021-06-21 16:03:24 +01:00
|
|
|
|
service = create_service()
|
2021-06-24 11:05:22 +01:00
|
|
|
|
api_key = create_api_key(service=service)
|
2021-06-21 16:03:24 +01:00
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
check_rate_limiting(service, api_key)
|
2021-06-21 16:03:24 +01:00
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
mock_rate_limit.assert_called_once_with(service, api_key)
|
|
|
|
|
|
mock_daily_limit.assert_called_once_with(api_key.key_type, service)
|
2021-06-21 16:03:24 +01:00
|
|
|
|
|
|
|
|
|
|
|
2017-04-26 15:56:45 +01:00
|
|
|
|
@pytest.mark.parametrize('key_type', ['test', 'normal'])
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_validate_and_format_recipient_fails_when_international_number_and_service_does_not_allow_int_sms(
|
2017-11-01 11:01:20 +00:00
|
|
|
|
key_type,
|
|
|
|
|
|
notify_db_session,
|
2017-10-19 11:06:28 +01:00
|
|
|
|
):
|
2019-10-31 15:02:30 +00:00
|
|
|
|
service = create_service(service_permissions=[SMS_TYPE])
|
2020-06-26 14:10:12 +01:00
|
|
|
|
service_model = SerialisedService.from_id(service.id)
|
2017-04-26 15:56:45 +01:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2020-06-26 14:10:12 +01:00
|
|
|
|
validate_and_format_recipient('20-12-1234-1234', key_type, service_model, SMS_TYPE)
|
2017-04-26 15:56:45 +01:00
|
|
|
|
assert e.value.status_code == 400
|
|
|
|
|
|
assert e.value.message == 'Cannot send to international mobile numbers'
|
|
|
|
|
|
assert e.value.fields == []
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('key_type', ['test', 'normal'])
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_validate_and_format_recipient_succeeds_with_international_numbers_if_service_does_allow_int_sms(
|
2019-10-31 15:02:30 +00:00
|
|
|
|
key_type, sample_service_full_permissions):
|
2020-06-26 14:10:12 +01:00
|
|
|
|
service_model = SerialisedService.from_id(sample_service_full_permissions.id)
|
|
|
|
|
|
result = validate_and_format_recipient('20-12-1234-1234', key_type, service_model, SMS_TYPE)
|
2017-04-26 15:56:45 +01:00
|
|
|
|
assert result == '201212341234'
|
2017-10-04 14:34:45 +01:00
|
|
|
|
|
|
|
|
|
|
|
2021-06-24 11:05:22 +01:00
|
|
|
|
def test_validate_and_format_recipient_fails_when_no_recipient():
|
2018-01-11 14:25:40 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
|
|
|
|
|
validate_and_format_recipient(None, 'key_type', 'service', 'SMS_TYPE')
|
|
|
|
|
|
assert e.value.status_code == 400
|
|
|
|
|
|
assert e.value.message == "Recipient can't be empty"
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-10-30 13:36:49 +00:00
|
|
|
|
@pytest.mark.parametrize('notification_type', ['sms', 'email', 'letter'])
|
|
|
|
|
|
def test_check_service_email_reply_to_id_where_reply_to_id_is_none(notification_type):
|
|
|
|
|
|
assert check_service_email_reply_to_id(None, None, notification_type) is None
|
2017-10-05 11:33:20 +01:00
|
|
|
|
|
|
|
|
|
|
|
2017-11-01 11:01:20 +00:00
|
|
|
|
def test_check_service_email_reply_to_where_email_reply_to_is_found(sample_service):
|
|
|
|
|
|
reply_to_address = create_reply_to_email(sample_service, "test@test.com")
|
2017-11-23 14:55:49 +00:00
|
|
|
|
assert check_service_email_reply_to_id(sample_service.id, reply_to_address.id, EMAIL_TYPE) == "test@test.com"
|
2017-11-01 11:01:20 +00:00
|
|
|
|
|
|
|
|
|
|
|
2017-10-05 11:33:20 +01:00
|
|
|
|
def test_check_service_email_reply_to_id_where_service_id_is_not_found(sample_service, fake_uuid):
|
2017-10-05 13:22:00 +01:00
|
|
|
|
reply_to_address = create_reply_to_email(sample_service, "test@test.com")
|
2017-10-05 11:33:20 +01:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2017-10-30 13:36:49 +00:00
|
|
|
|
check_service_email_reply_to_id(fake_uuid, reply_to_address.id, EMAIL_TYPE)
|
2017-10-05 11:33:20 +01:00
|
|
|
|
assert e.value.status_code == 400
|
2017-11-01 11:01:20 +00:00
|
|
|
|
assert e.value.message == 'email_reply_to_id {} does not exist in database for service id {}' \
|
2017-10-05 13:22:00 +01:00
|
|
|
|
.format(reply_to_address.id, fake_uuid)
|
2017-10-04 14:34:45 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_service_email_reply_to_id_where_reply_to_id_is_not_found(sample_service, fake_uuid):
|
|
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2017-10-30 13:36:49 +00:00
|
|
|
|
check_service_email_reply_to_id(sample_service.id, fake_uuid, EMAIL_TYPE)
|
2017-10-04 14:34:45 +01:00
|
|
|
|
assert e.value.status_code == 400
|
2017-11-01 11:01:20 +00:00
|
|
|
|
assert e.value.message == 'email_reply_to_id {} does not exist in database for service id {}' \
|
2017-10-05 13:22:00 +01:00
|
|
|
|
.format(fake_uuid, sample_service.id)
|
2017-10-04 14:34:45 +01:00
|
|
|
|
|
|
|
|
|
|
|
2017-10-30 13:36:49 +00:00
|
|
|
|
@pytest.mark.parametrize('notification_type', ['sms', 'email', 'letter'])
|
2017-11-01 11:01:20 +00:00
|
|
|
|
def test_check_service_sms_sender_id_where_sms_sender_id_is_none(notification_type):
|
2017-10-30 13:36:49 +00:00
|
|
|
|
assert check_service_sms_sender_id(None, None, notification_type) is None
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-11-01 11:01:20 +00:00
|
|
|
|
def test_check_service_sms_sender_id_where_sms_sender_id_is_found(sample_service):
|
2017-10-30 13:36:49 +00:00
|
|
|
|
sms_sender = create_service_sms_sender(service=sample_service, sms_sender='123456')
|
2017-11-10 14:17:29 +00:00
|
|
|
|
assert check_service_sms_sender_id(sample_service.id, sms_sender.id, SMS_TYPE) == '123456'
|
2017-10-30 13:36:49 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_service_sms_sender_id_where_service_id_is_not_found(sample_service, fake_uuid):
|
|
|
|
|
|
sms_sender = create_service_sms_sender(service=sample_service, sms_sender='123456')
|
|
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
|
|
|
|
|
check_service_sms_sender_id(fake_uuid, sms_sender.id, SMS_TYPE)
|
|
|
|
|
|
assert e.value.status_code == 400
|
2017-11-01 11:01:20 +00:00
|
|
|
|
assert e.value.message == 'sms_sender_id {} does not exist in database for service id {}' \
|
2017-10-30 13:36:49 +00:00
|
|
|
|
.format(sms_sender.id, fake_uuid)
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-11-01 11:01:20 +00:00
|
|
|
|
def test_check_service_sms_sender_id_where_sms_sender_is_not_found(sample_service, fake_uuid):
|
2017-10-30 13:36:49 +00:00
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
|
|
|
|
|
check_service_sms_sender_id(sample_service.id, fake_uuid, SMS_TYPE)
|
|
|
|
|
|
assert e.value.status_code == 400
|
2017-11-01 11:01:20 +00:00
|
|
|
|
assert e.value.message == 'sms_sender_id {} does not exist in database for service id {}' \
|
2017-10-30 13:36:49 +00:00
|
|
|
|
.format(fake_uuid, sample_service.id)
|
2017-12-15 16:51:40 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_service_letter_contact_id_where_letter_contact_id_is_none():
|
|
|
|
|
|
assert check_service_letter_contact_id(None, None, 'letter') is None
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_service_letter_contact_id_where_letter_contact_id_is_found(sample_service):
|
|
|
|
|
|
letter_contact = create_letter_contact(service=sample_service, contact_block='123456')
|
|
|
|
|
|
assert check_service_letter_contact_id(sample_service.id, letter_contact.id, LETTER_TYPE) == '123456'
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_service_letter_contact_id_where_service_id_is_not_found(sample_service, fake_uuid):
|
|
|
|
|
|
letter_contact = create_letter_contact(service=sample_service, contact_block='123456')
|
|
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
|
|
|
|
|
check_service_letter_contact_id(fake_uuid, letter_contact.id, LETTER_TYPE)
|
|
|
|
|
|
assert e.value.status_code == 400
|
|
|
|
|
|
assert e.value.message == 'letter_contact_id {} does not exist in database for service id {}' \
|
|
|
|
|
|
.format(letter_contact.id, fake_uuid)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_service_letter_contact_id_where_letter_contact_is_not_found(sample_service, fake_uuid):
|
|
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
|
|
|
|
|
check_service_letter_contact_id(sample_service.id, fake_uuid, LETTER_TYPE)
|
|
|
|
|
|
assert e.value.status_code == 400
|
|
|
|
|
|
assert e.value.message == 'letter_contact_id {} does not exist in database for service id {}' \
|
|
|
|
|
|
.format(fake_uuid, sample_service.id)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('notification_type', ['sms', 'email', 'letter'])
|
|
|
|
|
|
def test_check_reply_to_with_empty_reply_to(sample_service, notification_type):
|
|
|
|
|
|
assert check_reply_to(sample_service.id, None, notification_type) is None
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_reply_to_email_type(sample_service):
|
|
|
|
|
|
reply_to_address = create_reply_to_email(sample_service, "test@test.com")
|
|
|
|
|
|
assert check_reply_to(sample_service.id, reply_to_address.id, EMAIL_TYPE) == 'test@test.com'
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_reply_to_sms_type(sample_service):
|
|
|
|
|
|
sms_sender = create_service_sms_sender(service=sample_service, sms_sender='123456')
|
|
|
|
|
|
assert check_reply_to(sample_service.id, sms_sender.id, SMS_TYPE) == '123456'
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_reply_to_letter_type(sample_service):
|
|
|
|
|
|
letter_contact = create_letter_contact(service=sample_service, contact_block='123456')
|
|
|
|
|
|
assert check_reply_to(sample_service.id, letter_contact.id, LETTER_TYPE) == '123456'
|
2020-02-25 16:11:53 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_if_service_can_send_files_by_email_raises_if_no_contact_link_set(sample_service):
|
|
|
|
|
|
with pytest.raises(BadRequestError) as e:
|
2020-02-26 16:04:15 +00:00
|
|
|
|
check_if_service_can_send_files_by_email(
|
|
|
|
|
|
service_contact_link=sample_service.contact_link,
|
|
|
|
|
|
service_id=sample_service.id
|
|
|
|
|
|
)
|
2020-02-25 17:10:22 +00:00
|
|
|
|
|
2020-02-26 16:04:15 +00:00
|
|
|
|
message = f"Send files by email has not been set up - add contact details for your service at " \
|
|
|
|
|
|
f"http://localhost:6012/services/{sample_service.id}/service-settings/send-files-by-email"
|
2020-02-25 16:11:53 +00:00
|
|
|
|
assert e.value.status_code == 400
|
2020-02-26 10:40:12 +00:00
|
|
|
|
assert e.value.message == message
|
2020-02-25 16:11:53 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_check_if_service_can_send_files_by_email_passes_if_contact_link_set(sample_service):
|
|
|
|
|
|
sample_service.contact_link = 'contact.me@gov.uk'
|
2020-02-26 16:04:15 +00:00
|
|
|
|
check_if_service_can_send_files_by_email(
|
|
|
|
|
|
service_contact_link=sample_service.contact_link,
|
|
|
|
|
|
service_id=sample_service.id
|
|
|
|
|
|
)
|
2020-07-29 14:52:18 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('key, address_line_3, expected_postage',
|
|
|
|
|
|
[('address_line_3', 'SW1 1AA', None),
|
|
|
|
|
|
('address_line_5', 'CANADA', 'rest-of-world'),
|
|
|
|
|
|
('address_line_3', 'GERMANY', 'europe')
|
|
|
|
|
|
])
|
|
|
|
|
|
def test_validate_address(notify_db_session, key, address_line_3, expected_postage):
|
|
|
|
|
|
service = create_service(service_permissions=[LETTER_TYPE, INTERNATIONAL_LETTERS])
|
|
|
|
|
|
data = {
|
|
|
|
|
|
'address_line_1': 'Prince Harry',
|
|
|
|
|
|
'address_line_2': 'Toronto',
|
|
|
|
|
|
key: address_line_3,
|
|
|
|
|
|
}
|
|
|
|
|
|
postage = validate_address(service, data)
|
|
|
|
|
|
assert postage == expected_postage
|