app/delivery/rest.py

from flask import Blueprint, jsonify

from app.delivery import send_to_providers
from app.models import EMAIL_TYPE
from app.celery import provider_tasks
from app.dao import notifications_dao

delivery = Blueprint('delivery', __name__)

from app.errors import register_errors

register_errors(delivery)


@delivery.route('/deliver/notification/<uuid:notification_id>',  methods=['POST'])
def send_notification_to_provider(notification_id):

    notification = notifications_dao.get_notification_by_id(notification_id)
    if not notification:
        return jsonify(notification={"result": "error", "message": "No result found"}), 404

    if notification.notification_type == EMAIL_TYPE:
        send_response(send_to_providers.send_email_response, provider_tasks.deliver_email, notification_id, 'send-email')
    else:
        send_response(send_to_providers.send_sms_response, provider_tasks.deliver_sms, notification_id, 'send-sms')
    return jsonify({}), 204


def send_response(send_call, task_call, notification, queue):
    try:
        send_call(notification)
    except Exception as e:
        task_call.apply_async((str(notification.id)), queue=queue)
Refactoring the send to provider code out of the tasks folder - building a rest endpoint to call that code to compliment the existing task based approach. 2016-09-21 13:27:32 +01:00			`from flask import Blueprint, jsonify`

			`from app.delivery import send_to_providers`
			`from app.models import EMAIL_TYPE`
			`from app.celery import provider_tasks`
Refactor to make the new send_to_provider methods take a notification not a notification ID. - Driven by the fact we won't know the type in the API call - hence we need to load notification earlier , so pass it not the id through to the send task to avoid loading it twice. 2016-09-22 09:16:58 +01:00			`from app.dao import notifications_dao`
Refactoring the send to provider code out of the tasks folder - building a rest endpoint to call that code to compliment the existing task based approach. 2016-09-21 13:27:32 +01:00
			`delivery = Blueprint('delivery', __name__)`

Refactor to make the new send_to_provider methods take a notification not a notification ID. - Driven by the fact we won't know the type in the API call - hence we need to load notification earlier , so pass it not the id through to the send task to avoid loading it twice. 2016-09-22 09:16:58 +01:00			`from app.errors import register_errors`
Refactoring the send to provider code out of the tasks folder - building a rest endpoint to call that code to compliment the existing task based approach. 2016-09-21 13:27:32 +01:00
			`register_errors(delivery)`


			`@delivery.route('/deliver/notification/<uuid:notification_id>', methods=['POST'])`
Refactor to make the new send_to_provider methods take a notification not a notification ID. - Driven by the fact we won't know the type in the API call - hence we need to load notification earlier , so pass it not the id through to the send task to avoid loading it twice. 2016-09-22 09:16:58 +01:00			`def send_notification_to_provider(notification_id):`
Refactoring the send to provider code out of the tasks folder - building a rest endpoint to call that code to compliment the existing task based approach. 2016-09-21 13:27:32 +01:00
Refactor to make the new send_to_provider methods take a notification not a notification ID. - Driven by the fact we won't know the type in the API call - hence we need to load notification earlier , so pass it not the id through to the send task to avoid loading it twice. 2016-09-22 09:16:58 +01:00			`notification = notifications_dao.get_notification_by_id(notification_id)`
			`if not notification:`
			`return jsonify(notification={"result": "error", "message": "No result found"}), 404`

			`if notification.notification_type == EMAIL_TYPE:`
Refactoring the send to provider code out of the tasks folder - building a rest endpoint to call that code to compliment the existing task based approach. 2016-09-21 13:27:32 +01:00			`send_response(send_to_providers.send_email_response, provider_tasks.deliver_email, notification_id, 'send-email')`
			`else:`
			`send_response(send_to_providers.send_sms_response, provider_tasks.deliver_sms, notification_id, 'send-sms')`
			`return jsonify({}), 204`


Refactor to make the new send_to_provider methods take a notification not a notification ID. - Driven by the fact we won't know the type in the API call - hence we need to load notification earlier , so pass it not the id through to the send task to avoid loading it twice. 2016-09-22 09:16:58 +01:00			`def send_response(send_call, task_call, notification, queue):`
Refactoring the send to provider code out of the tasks folder - building a rest endpoint to call that code to compliment the existing task based approach. 2016-09-21 13:27:32 +01:00			`try:`
Refactor to make the new send_to_provider methods take a notification not a notification ID. - Driven by the fact we won't know the type in the API call - hence we need to load notification earlier , so pass it not the id through to the send task to avoid loading it twice. 2016-09-22 09:16:58 +01:00			`send_call(notification)`
Refactoring the send to provider code out of the tasks folder - building a rest endpoint to call that code to compliment the existing task based approach. 2016-09-21 13:27:32 +01:00			`except Exception as e:`
Refactor to make the new send_to_provider methods take a notification not a notification ID. - Driven by the fact we won't know the type in the API call - hence we need to load notification earlier , so pass it not the id through to the send task to avoid loading it twice. 2016-09-22 09:16:58 +01:00			`task_call.apply_async((str(notification.id)), queue=queue)`